-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core-api][experimental] AssetSelection.tag #26697
Open
OwenKephart
wants to merge
1
commit into
12-23-_core-api_experimental_table_metadata
Choose a base branch
from
12-23-_core-api_experimental_assetselection.tag
base: 12-23-_core-api_experimental_table_metadata
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[core-api][experimental] AssetSelection.tag #26697
OwenKephart
wants to merge
1
commit into
12-23-_core-api_experimental_table_metadata
from
12-23-_core-api_experimental_assetselection.tag
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
OwenKephart
force-pushed
the
12-23-_core-api_experimental_automationconditionsensordefinition
branch
from
December 23, 2024 21:55
bfade49
to
a9b8112
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_assetselection.tag
branch
from
December 23, 2024 21:55
e4d88f7
to
f66e7e5
Compare
yuhan
reviewed
Dec 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move tag
out of experimental makes sense. had one question about the param.
@@ -240,7 +240,7 @@ def groups(*group_strs, include_sources: bool = False) -> "GroupsAssetSelection" | |||
|
|||
@public | |||
@staticmethod | |||
@experimental | |||
@experimental_param(param="include_sources") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this experimental?
Draft
OwenKephart
force-pushed
the
12-23-_core-api_experimental_automationconditionsensordefinition
branch
from
December 31, 2024 18:47
a9b8112
to
01dc421
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_assetselection.tag
branch
from
December 31, 2024 18:47
f66e7e5
to
cfcadea
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_automationconditionsensordefinition
branch
from
December 31, 2024 19:17
01dc421
to
97c20c1
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_assetselection.tag
branch
from
December 31, 2024 19:19
cfcadea
to
e7362d3
Compare
OwenKephart
changed the base branch from
12-23-_core-api_experimental_automationconditionsensordefinition
to
12-23-_core-api_experimental_table_metadata
December 31, 2024 19:19
OwenKephart
force-pushed
the
12-23-_core-api_experimental_table_metadata
branch
from
December 31, 2024 19:30
bdb8f2c
to
058bd67
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_assetselection.tag
branch
from
December 31, 2024 19:30
e7362d3
to
709d87e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
decision: experimental -> GA
reason: this has existed for a long time, we need to support it for the new asset selection syntax, and there's no reason that we would not want to support this behavior
docs exist: yes (API only, which is ok)
How I Tested These Changes
Changelog