Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-api][experimental] AssetSelection.tag #26697

Open
wants to merge 1 commit into
base: 12-23-_core-api_experimental_table_metadata
Choose a base branch
from

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

decision: experimental -> GA
reason: this has existed for a long time, we need to support it for the new asset selection syntax, and there's no reason that we would not want to support this behavior
docs exist: yes (API only, which is ok)

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

Copy link
Contributor Author

OwenKephart commented Dec 23, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

@yuhan yuhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move tag out of experimental makes sense. had one question about the param.

@@ -240,7 +240,7 @@ def groups(*group_strs, include_sources: bool = False) -> "GroupsAssetSelection"

@public
@staticmethod
@experimental
@experimental_param(param="include_sources")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this experimental?

@OwenKephart OwenKephart mentioned this pull request Dec 31, 2024
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_automationconditionsensordefinition branch from a9b8112 to 01dc421 Compare December 31, 2024 18:47
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_assetselection.tag branch from f66e7e5 to cfcadea Compare December 31, 2024 18:47
@OwenKephart OwenKephart marked this pull request as ready for review December 31, 2024 18:51
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_automationconditionsensordefinition branch from 01dc421 to 97c20c1 Compare December 31, 2024 19:17
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_assetselection.tag branch from cfcadea to e7362d3 Compare December 31, 2024 19:19
@OwenKephart OwenKephart changed the base branch from 12-23-_core-api_experimental_automationconditionsensordefinition to 12-23-_core-api_experimental_table_metadata December 31, 2024 19:19
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_table_metadata branch from bdb8f2c to 058bd67 Compare December 31, 2024 19:30
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_assetselection.tag branch from e7362d3 to 709d87e Compare December 31, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants