[core-api][experimental] include_sources -> include_external_assets #26710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
OwenKephart
force-pushed
the
12-23-_core-api_experimental_repository_def_in_runstatussensordefinition
branch
from
d403149 to
963472e
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_include_sources_-_include_external_assets
branch
from
7352dfd to
4be75ae
Compare
yuhan
approved these changes
Dec 26, 2024
Draft
OwenKephart
force-pushed
the
12-23-_core-api_experimental_repository_def_in_runstatussensordefinition
branch
from
963472e to
4a7e5a7
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_include_sources_-_include_external_assets
branch
from
4be75ae to
d3182b6
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_repository_def_in_runstatussensordefinition
branch
from
4a7e5a7 to
1338be1
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_include_sources_-_include_external_assets
branch
from
d3182b6 to
6a82d5d
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_repository_def_in_runstatussensordefinition
branch
from
1338be1 to
c22804c
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_include_sources_-_include_external_assets
branch
from
6a82d5d to
c9e844d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
decision: experimental -> GA (after parameter change)
reason: if we're going to make this change, we should acompany it with marking this API as stable (i.e. we should only make the name change once). "source assets" as a concept no longer really exist, and external assets is the more general term (and more accurate to what these parameters were actually filtering for.
docs exist: yes (api only, which is ok)
How I Tested These Changes
Changelog