[core-api][experimental] observable_source_asset, multi_observable_source_asset #26706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
OwenKephart
requested review from
maximearmstrong,
schrockn,
smackesey and
yuhan
OwenKephart
changed the title
OwenKephart
force-pushed
the
12-23-_core-apis_experimental_definitions.get_all_asset_specs_definitions.with_reconstruction_metadata
branch
from
991c6c0 to
73e3a15
Compare
OwenKephart
force-pushed
the
12-23-_core-apis_experimental_observable_source_asset_multi_observable_source_asset
branch
from
72bc4c7 to
11433a6
Compare
yuhan
requested changes
Dec 26, 2024
|
Agree with yuhan. We need to replace source asset with external asset language and this is an oversight, so Beta doesn't really communicate this accurately. |
Draft
OwenKephart
force-pushed
the
12-23-_core-apis_experimental_definitions.get_all_asset_specs_definitions.with_reconstruction_metadata
branch
from
73e3a15 to
9712a54
Compare
OwenKephart
force-pushed
the
12-23-_core-apis_experimental_observable_source_asset_multi_observable_source_asset
branch
from
11433a6 to
0ba9041
Compare
OwenKephart
force-pushed
the
12-23-_core-apis_experimental_definitions.get_all_asset_specs_definitions.with_reconstruction_metadata
branch
from
9712a54 to
b1446c6
Compare
OwenKephart
force-pushed
the
12-23-_core-apis_experimental_observable_source_asset_multi_observable_source_asset
branch
from
0ba9041 to
6af0044
Compare
OwenKephart
force-pushed
the
12-23-_core-apis_experimental_definitions.get_all_asset_specs_definitions.with_reconstruction_metadata
branch
from
b1446c6 to
2487afe
Compare
OwenKephart
force-pushed
the
12-23-_core-apis_experimental_observable_source_asset_multi_observable_source_asset
branch
from
6af0044 to
d182b8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
decision: experimental -> beta
reason: we have aspirations of simplifying the ways in which we define asset observation computations, let's leave the option value open to change names on these APIs
docs exist: n/a
How I Tested These Changes
Changelog