-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core-api][experimental] repository_def in RunStatusSensorDefinition #26709
Open
OwenKephart
wants to merge
1
commit into
12-23-_core-api_experimental_allow_nonexistent_upstream_partitions
Choose a base branch
from
12-23-_core-api_experimental_repository_def_in_runstatussensordefinition
base: 12-23-_core-api_experimental_allow_nonexistent_upstream_partitions
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
OwenKephart
force-pushed
the
12-23-_core-api_experimental_allow_nonexistent_upstream_partitions
branch
from
December 23, 2024 21:56
078d1d8
to
9e18b12
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_repository_def_in_runstatussensordefinition
branch
from
December 23, 2024 21:56
d403149
to
963472e
Compare
is renaming to some code location an option here? i think if we'd introduce a code-location friendly name, we may as well just deprecate this instead of moving to GA? |
Draft
OwenKephart
force-pushed
the
12-23-_core-api_experimental_allow_nonexistent_upstream_partitions
branch
from
December 31, 2024 18:48
9e18b12
to
011b975
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_repository_def_in_runstatussensordefinition
branch
from
December 31, 2024 18:48
963472e
to
4a7e5a7
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_allow_nonexistent_upstream_partitions
branch
from
December 31, 2024 19:20
011b975
to
65062e3
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_repository_def_in_runstatussensordefinition
branch
from
December 31, 2024 19:20
4a7e5a7
to
1338be1
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_allow_nonexistent_upstream_partitions
branch
from
December 31, 2024 19:31
65062e3
to
442f718
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_repository_def_in_runstatussensordefinition
branch
from
December 31, 2024 19:31
1338be1
to
c22804c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
decision: experimental -> beta
reason: this is an unfortunate case where a fairly-new option actually ended up needing to reference the superseded repository API. we should fix that before making this GA (and this is a fairly niche option)
docs exist: n/a
How I Tested These Changes
Changelog