[core-api][experimental] InputDefinition
#26683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
OwenKephart
force-pushed
the
12-23-_core-api_experimental_create_external_assets_from_specs_
branch
from
7b11644 to
e56c48e
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_inputdefinition_
branch
from
675e3ca to
6e9286c
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_create_external_assets_from_specs_
branch
from
e56c48e to
f969357
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_inputdefinition_
branch
from
6e9286c to
f2e1301
Compare
Draft
OwenKephart
force-pushed
the
12-23-_core-api_experimental_create_external_assets_from_specs_
branch
from
f969357 to
d009560
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_inputdefinition_
branch
from
f2e1301 to
f48c480
Compare
## Summary & Motivation decision: experimental -> beta reason: these APIs feel "not quite done", and we may want to refactor them in the future. In particular, building a sensor for freshness checks might not make the most sense -- we may want to just automatically add AutomationConditions to the checks docs exist: yes ## How I Tested These Changes ## Changelog > Insert changelog entry or delete this section.
OwenKephart
merged commit 407239d
into
12-23-_core-api_experimental_create_external_assets_from_specs_
1 check was pending
OwenKephart
deleted the
12-23-_core-api_experimental_inputdefinition_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
decision: experimental params -> superseded
reason: InputDefinition is a very old API that does not really exist in modern-day dagster. explicitly categorizing params for such an old API as experimental seems wasteful, so I just marked the entire class as superseded
docs exist: n/a
How I Tested These Changes
Changelog