[core-api][experimental] AssetOut tags #26689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
OwenKephart
force-pushed
the
12-23-_core-api_experimental_direct_resource_passing
branch
from
70ceb12 to
6b3e956
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_assetout_tags
branch
from
84591b1 to
fa417d5
Compare
yuhan
approved these changes
Dec 26, 2024
OwenKephart
force-pushed
the
12-23-_core-api_experimental_direct_resource_passing
branch
from
6b3e956 to
19f02c5
Compare
Draft
OwenKephart
force-pushed
the
12-23-_core-api_experimental_assetout_tags
branch
from
fa417d5 to
fe82fe7
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_assetout_tags
branch
from
fe82fe7 to
19880aa
Compare
OwenKephart
changed the base branch from
12-23-_core-api_experimental_direct_resource_passing
to
12-23-_core-api_experimental_owners_
## Summary & Motivation decision: experimental -> public reason: we are using this pattern heavily internally, and generally have built up a lot of APIs around making this sort of thing work. we want people to be using this pattern in other places (e.g. multi_asset), so it shouldn't be marked as experimental docs exist: yes (api only, which is ok) ## How I Tested These Changes ## Changelog > Insert changelog entry or delete this section.
OwenKephart
merged commit a8eba8c
into
12-23-_core-api_experimental_owners_
1 check was pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
decision: experimental -> GA
reason: we like having tags on our objects, this is no exception, I see no reason why we would ever change this behavior
docs exist: yes (api only, which is ok)
How I Tested These Changes
Changelog