Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core-api][experimental] execution type #26695

Open
wants to merge 1 commit into
base: 12-23-_core-api_experimental_freshness_policy_param
Choose a base branch
from
Open

[core-api][experimental] execution type #26695

wants to merge 1 commit into from

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

decision: experimental -> beta
reason: we will likely retain some version of this parameter, but low confidence on this being the final name / form
docs: n/a

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

This was referenced Dec 23, 2024
Merged
Open
Merged
Merged
Merged
Merged
Open
Open
Open
Merged
Open
Merged
Merged
Open
Open
Merged
@OwenKephart Graphite App
Copy link
Contributor Author

OwenKephart commented Dec 23, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Dec 23, 2024
Open
Merged
Open
Open
Merged
Merged
Merged
Open
This was referenced Dec 23, 2024
Open
Open
Open
This was referenced Dec 23, 2024
Open
Merged
Open
Open
Open
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_backfillpolicy branch from 9ebd887 to e6c0b94 Compare December 23, 2024 21:55
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_execution_type branch from 7bffd8a to 9aa9461 Compare December 23, 2024 21:55
@OwenKephart OwenKephart mentioned this pull request Dec 23, 2024
Open
yuhan
yuhan approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@yuhan yuhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't even know this existed. yeah i think beta is right as we may need to gain more confidence in how we model execution type, or we may need to remodel it.

@OwenKephart OwenKephart mentioned this pull request Dec 31, 2024
Draft
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_backfillpolicy branch from e6c0b94 to 5fa3ac5 Compare December 31, 2024 18:47
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_execution_type branch from 9aa9461 to c380277 Compare December 31, 2024 18:47
@OwenKephart OwenKephart marked this pull request as ready for review December 31, 2024 18:51
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_backfillpolicy branch from 5fa3ac5 to e3b0934 Compare December 31, 2024 19:19
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_execution_type branch from c380277 to d00d951 Compare December 31, 2024 19:19
@OwenKephart OwenKephart changed the base branch from 12-23-_core-api_experimental_backfillpolicy to 12-23-_core-api_experimental_freshness_policy_param December 31, 2024 19:20
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_freshness_policy_param branch from 4d3f937 to 7ab92ce Compare December 31, 2024 19:31
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_execution_type branch from d00d951 to 9d0fffe Compare December 31, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhan yuhan yuhan approved these changes

@maximearmstrong maximearmstrong Awaiting requested review from maximearmstrong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OwenKephart @yuhan