-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core-api][experimental] build_reconstructable_job
#26690
Merged
OwenKephart
merged 2 commits into
12-23-_core-api_experimental_source_code_metadata
from
12-23-_core-api_experimental_build_reconstructable_job_
Dec 31, 2024
Merged
[core-api][experimental] build_reconstructable_job
#26690
OwenKephart
merged 2 commits into
12-23-_core-api_experimental_source_code_metadata
from
12-23-_core-api_experimental_build_reconstructable_job_
Dec 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
OwenKephart
force-pushed
the
12-23-_core-api_experimental_assetout_tags
branch
from
December 23, 2024 21:55
84591b1
to
fa417d5
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_build_reconstructable_job_
branch
from
December 23, 2024 21:55
cfdb66b
to
a5649c3
Compare
yuhan
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i totally forgot why this was experimental in the first place.
Draft
OwenKephart
force-pushed
the
12-23-_core-api_experimental_assetout_tags
branch
from
December 31, 2024 18:47
fa417d5
to
fe82fe7
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_build_reconstructable_job_
branch
from
December 31, 2024 18:47
a5649c3
to
def7773
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_build_reconstructable_job_
branch
from
December 31, 2024 19:18
def7773
to
734f308
Compare
OwenKephart
changed the base branch from
12-23-_core-api_experimental_assetout_tags
to
12-23-_core-api_experimental_source_code_metadata
December 31, 2024 19:18
## Summary & Motivation decision: experimental -> public reason: we rely on this functionality fairly heavily internally, making it unlikely that we could change it even if we wanted to (beyond a name change, which is easy enough to do in a non-breaking way in the future) docs exist: yes (api only, which is ok) ## How I Tested These Changes ## Changelog > Insert changelog entry or delete this section.
OwenKephart
merged commit Dec 31, 2024
cd92ce5
into
12-23-_core-api_experimental_source_code_metadata
1 check was pending
OwenKephart
deleted the
12-23-_core-api_experimental_build_reconstructable_job_
branch
December 31, 2024 19:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
decision: experimental -> GA
reason: this is a 4 year old API, there are niche situations in which it is useful, and I see zero reason that we would break it
docs exist: yes (api only, which is ok)
How I Tested These Changes
Changelog