Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-api][experimental] build_reconstructable_job #26690

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

decision: experimental -> GA
reason: this is a 4 year old API, there are niche situations in which it is useful, and I see zero reason that we would break it
docs exist: yes (api only, which is ok)

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

Copy link
Contributor

@yuhan yuhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i totally forgot why this was experimental in the first place.

@OwenKephart OwenKephart mentioned this pull request Dec 31, 2024
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_assetout_tags branch from fa417d5 to fe82fe7 Compare December 31, 2024 18:47
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_build_reconstructable_job_ branch from a5649c3 to def7773 Compare December 31, 2024 18:47
@OwenKephart OwenKephart marked this pull request as ready for review December 31, 2024 18:51
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_build_reconstructable_job_ branch from def7773 to 734f308 Compare December 31, 2024 19:18
@OwenKephart OwenKephart changed the base branch from 12-23-_core-api_experimental_assetout_tags to 12-23-_core-api_experimental_source_code_metadata December 31, 2024 19:18
## Summary & Motivation

decision: experimental -> public
reason: we rely on this functionality fairly heavily internally, making
it unlikely that we could change it even if we wanted to (beyond a name
change, which is easy enough to do in a non-breaking way in the future)
docs exist: yes (api only, which is ok)

## How I Tested These Changes

## Changelog

> Insert changelog entry or delete this section.
@OwenKephart OwenKephart merged commit cd92ce5 into 12-23-_core-api_experimental_source_code_metadata Dec 31, 2024
1 check was pending
@OwenKephart OwenKephart deleted the 12-23-_core-api_experimental_build_reconstructable_job_ branch December 31, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants