[core-api][experimental] create_external_assets_from_specs
#26682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
OwenKephart
force-pushed
the
12-23-_core-api_experimental_assetsdefinition_specs_
branch
from
975219b to
1bc02f6
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_create_external_assets_from_specs_
branch
from
7b11644 to
e56c48e
Compare
yuhan
approved these changes
Dec 26, 2024
OwenKephart
force-pushed
the
12-23-_core-api_experimental_assetsdefinition_specs_
branch
from
1bc02f6 to
a2c81e9
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_create_external_assets_from_specs_
branch
from
e56c48e to
f969357
Compare
Draft
OwenKephart
force-pushed
the
12-23-_core-api_experimental_assetsdefinition_specs_
branch
from
a2c81e9 to
fe2e711
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_create_external_assets_from_specs_
branch
from
f969357 to
d009560
Compare
## Summary & Motivation decision: experimental params -> superseded reason: InputDefinition is a very old API that does not really exist in modern-day dagster. explicitly categorizing params for such an old API as experimental seems wasteful, so I just marked the entire class as superseded docs exist: n/a ## How I Tested These Changes ## Changelog > Insert changelog entry or delete this section.
OwenKephart
merged commit dd08315
into
12-23-_core-api_experimental_assetsdefinition_specs_
1 check was pending
OwenKephart
deleted the
12-23-_core-api_experimental_create_external_assets_from_specs_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
decision: experimental -> deprecated
reason: this was actually marked as both experimental and deprecated, which doesn't make sense
docs exist: n/a
How I Tested These Changes
Changelog