[core-api][experimental] ObserveResult #26701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
OwenKephart
force-pushed
the
12-23-_core-api_experimental_freshness_checks
branch
from
5633503 to
fde5e47
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_observeresult
branch
from
fa3c8a0 to
a44d76a
Compare
yuhan
approved these changes
Dec 26, 2024
how would you like to track the docs work? |
Draft
OwenKephart
force-pushed
the
12-23-_core-api_experimental_freshness_checks
branch
from
fde5e47 to
590cb97
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_observeresult
branch
from
a44d76a to
2fcbc04
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_observeresult
branch
from
2fcbc04 to
020b0d3
Compare
OwenKephart
changed the base branch from
12-23-_core-api_experimental_freshness_checks
to
12-23-_core-apis_experimental_automationcondition.any_downstream_conditions
## Summary & Motivation decision: experimental -> superseded reason: while this API does support some cases that DA does not, in the vast majority of cases it will be significantly easier to implement equivalent functionality in DA, so we want to avoid retaining documentation for this pattern and potentially causing confusion. There's no reason for existing users to stop using multi asset sensors though, hence this not being marked as deprecated docs exist: no (on purpose) ## How I Tested These Changes ## Changelog > Insert changelog entry or delete this section.
OwenKephart
merged commit ed8201c
into
12-23-_core-apis_experimental_automationcondition.any_downstream_conditions
1 check was pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
decision: experimental -> GA
reason: given that we've bought in heavily to MaterializeResult, it seems natural to promote this pattern as well
docs exist: no (api only, needs to be added to: https://docs.dagster.io/concepts/assets/asset-observations#asset-observations)
How I Tested These Changes
Changelog