-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core-api][experimental] exclude_subruns #26687
Merged
OwenKephart
merged 2 commits into
12-23-_core-api_experimental_build_reconstructable_job_
from
12-23-_core-api_experimental_exclude_subruns
Dec 31, 2024
Merged
[core-api][experimental] exclude_subruns #26687
OwenKephart
merged 2 commits into
12-23-_core-api_experimental_build_reconstructable_job_
from
12-23-_core-api_experimental_exclude_subruns
Dec 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
jamiedemaria
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
OwenKephart
force-pushed
the
12-23-_core-api_experimental_multi_partition_mappings
branch
from
December 23, 2024 21:54
75e0102
to
54453df
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_exclude_subruns
branch
from
December 23, 2024 21:54
b31ab31
to
85477ee
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_multi_partition_mappings
branch
from
December 31, 2024 18:46
54453df
to
bcdc49a
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_exclude_subruns
branch
from
December 31, 2024 18:47
85477ee
to
29d9049
Compare
Draft
OwenKephart
force-pushed
the
12-23-_core-api_experimental_exclude_subruns
branch
from
December 31, 2024 19:18
29d9049
to
8124d05
Compare
OwenKephart
changed the base branch from
12-23-_core-api_experimental_multi_partition_mappings
to
12-23-_core-api_experimental_build_reconstructable_job_
December 31, 2024 19:18
## Summary & Motivation decision: experimental -> public reason: been in use for a long time, and we're committed to the feature docs exist: yes ## How I Tested These Changes ## Changelog > Insert changelog entry or delete this section.
OwenKephart
merged commit Dec 31, 2024
6c7e648
into
12-23-_core-api_experimental_build_reconstructable_job_
1 check was pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
decision: experimental -> public
reason: we rely on this functionality fairly heavily internally, making it unlikely that we could change it even if we wanted to (beyond a name change, which is easy enough to do in a non-breaking way in the future)
docs exist: yes (api only, which is ok)
How I Tested These Changes
Changelog