Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-api][experimental] exclude_subruns #26687

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

decision: experimental -> public
reason: we rely on this functionality fairly heavily internally, making it unlikely that we could change it even if we wanted to (beyond a name change, which is easy enough to do in a non-breaking way in the future)
docs exist: yes (api only, which is ok)

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

Copy link
Contributor

@jamiedemaria jamiedemaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_multi_partition_mappings branch from 75e0102 to 54453df Compare December 23, 2024 21:54
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_exclude_subruns branch from b31ab31 to 85477ee Compare December 23, 2024 21:54
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_multi_partition_mappings branch from 54453df to bcdc49a Compare December 31, 2024 18:46
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_exclude_subruns branch from 85477ee to 29d9049 Compare December 31, 2024 18:47
@OwenKephart OwenKephart mentioned this pull request Dec 31, 2024
@OwenKephart OwenKephart marked this pull request as ready for review December 31, 2024 18:51
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_exclude_subruns branch from 29d9049 to 8124d05 Compare December 31, 2024 19:18
@OwenKephart OwenKephart changed the base branch from 12-23-_core-api_experimental_multi_partition_mappings to 12-23-_core-api_experimental_build_reconstructable_job_ December 31, 2024 19:18
## Summary & Motivation

decision: experimental -> public
reason: been in use for a long time, and we're committed to the feature
docs exist: yes

## How I Tested These Changes

## Changelog

> Insert changelog entry or delete this section.
@OwenKephart OwenKephart merged commit 6c7e648 into 12-23-_core-api_experimental_build_reconstructable_job_ Dec 31, 2024
1 check was pending
@OwenKephart OwenKephart deleted the 12-23-_core-api_experimental_exclude_subruns branch December 31, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants