Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-api][experimental] custom_path_fs_io_manager #26679

Open
wants to merge 1 commit into
base: 12-23-_core-api_experimental_definitions.merge_
Choose a base branch
from

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

decision: experimental -> public
reason: doubt many people are using this, but it has existed for many many years and there is no reason for us to remove support for it
docs exist: yes (api only, which is ok)

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

Copy link
Contributor Author

OwenKephart commented Dec 23, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@OwenKephart OwenKephart requested a review from yuhan December 23, 2024 18:28
Copy link
Contributor

yuhan commented Dec 26, 2024

This is the old resource pattern tho. should we mark it deprecated instead? it's successor is CustomPathPickledObjectFilesystemIOManager, but we don't really expose it and it'is also an ugly name.

Copy link
Contributor

@yuhan yuhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request changes just to keep track of the statuses

@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_report_runless_asset_event_ branch from 279e003 to 4df6dab Compare December 31, 2024 18:46
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_custom_path_fs_io_manager_ branch from b0d4528 to a0a1358 Compare December 31, 2024 18:46
@OwenKephart OwenKephart mentioned this pull request Dec 31, 2024
@OwenKephart OwenKephart marked this pull request as ready for review December 31, 2024 18:50
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_report_runless_asset_event_ branch from 4df6dab to eb93ea8 Compare December 31, 2024 19:18
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_custom_path_fs_io_manager_ branch from a0a1358 to d6685c8 Compare December 31, 2024 19:19
@OwenKephart OwenKephart changed the base branch from 12-23-_core-api_experimental_report_runless_asset_event_ to 12-23-_core-api_experimental_definitions.merge_ December 31, 2024 19:19
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_definitions.merge_ branch from 490e571 to ff38870 Compare December 31, 2024 19:31
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_custom_path_fs_io_manager_ branch from d6685c8 to bbb30b2 Compare December 31, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants