-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core-api][experimental] create_repository_using_definitions_args
#26703
Open
OwenKephart
wants to merge
1
commit into
12-23-_core-api_experimental_dataversion_assorted_apis
Choose a base branch
from
12-23-_core-api_experimental_create_repository_using_definitions_args_
base: 12-23-_core-api_experimental_dataversion_assorted_apis
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
OwenKephart
force-pushed
the
12-23-_core-api_experimental_freshness_policy_param
branch
from
December 23, 2024 21:56
0a78980
to
c2b91ad
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_create_repository_using_definitions_args_
branch
from
December 23, 2024 21:56
94f89e3
to
25d1bd6
Compare
yuhan
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i think this is important for the repository -> code location migration. probably should've been marked as GA when code location is GA
Draft
OwenKephart
force-pushed
the
12-23-_core-api_experimental_freshness_policy_param
branch
from
December 31, 2024 18:48
c2b91ad
to
49e2b30
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_create_repository_using_definitions_args_
branch
from
December 31, 2024 18:48
25d1bd6
to
632d3a9
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_create_repository_using_definitions_args_
branch
from
December 31, 2024 19:19
632d3a9
to
b534d44
Compare
OwenKephart
changed the base branch from
12-23-_core-api_experimental_freshness_policy_param
to
12-23-_core-api_experimental_dataversion_assorted_apis
December 31, 2024 19:19
OwenKephart
force-pushed
the
12-23-_core-api_experimental_dataversion_assorted_apis
branch
from
December 31, 2024 19:30
bc43343
to
fe518fd
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_create_repository_using_definitions_args_
branch
from
December 31, 2024 19:30
b534d44
to
7bec214
Compare
schrockn
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
decision: experimental -> GA
reason: this is a bit of glue code for users still using
@repository
, but there's no reason to delete it and we have no plans of changing it (plus it has existed for years).docs exist: yes (api only, which is ok)
How I Tested These Changes
Changelog