Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-api][experimental] AMP #26685

Open
wants to merge 1 commit into
base: 12-23-_core-api_experimental_get_asset_provenance_
Choose a base branch
from

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

decision: experimental -> deprecated
reason: it's deprecated, these callsites were missed earlier
docs exist: n/a

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

Copy link
Contributor Author

OwenKephart commented Dec 23, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@whitelist_for_serdes(
old_fields={"time_window_partition_scope_minutes": 1e-6},
serializer=AutoMaterializePolicySerializer,
)
@deprecated(breaking_version="1.10.0")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting. i thought we'd want to hold the breaking until some time in Q2

@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_get_asset_provenance_ branch from 90497f3 to 0ea96d8 Compare December 31, 2024 18:46
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_amp branch from ec805a4 to a553ee1 Compare December 31, 2024 18:46
@OwenKephart OwenKephart mentioned this pull request Dec 31, 2024
@OwenKephart OwenKephart marked this pull request as ready for review December 31, 2024 18:50
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_get_asset_provenance_ branch from 0ea96d8 to 07509f0 Compare December 31, 2024 19:18
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_amp branch from a553ee1 to 0e35f35 Compare December 31, 2024 19:18
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_get_asset_provenance_ branch from 07509f0 to 7611d3a Compare December 31, 2024 19:30
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_amp branch from 0e35f35 to 3c155bd Compare December 31, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants