-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core-api][experimental] AMP #26685
Open
OwenKephart
wants to merge
1
commit into
12-23-_core-api_experimental_get_asset_provenance_
Choose a base branch
from
12-23-_core-api_experimental_amp
base: 12-23-_core-api_experimental_get_asset_provenance_
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[core-api][experimental] AMP #26685
OwenKephart
wants to merge
1
commit into
12-23-_core-api_experimental_get_asset_provenance_
from
12-23-_core-api_experimental_amp
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
OwenKephart
force-pushed
the
12-23-_core-api_experimental_get_asset_provenance_
branch
from
December 23, 2024 21:54
1d7933d
to
90497f3
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_amp
branch
from
December 23, 2024 21:54
2e8e63b
to
ec805a4
Compare
yuhan
reviewed
Dec 26, 2024
@whitelist_for_serdes( | ||
old_fields={"time_window_partition_scope_minutes": 1e-6}, | ||
serializer=AutoMaterializePolicySerializer, | ||
) | ||
@deprecated(breaking_version="1.10.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting. i thought we'd want to hold the breaking until some time in Q2
OwenKephart
force-pushed
the
12-23-_core-api_experimental_get_asset_provenance_
branch
from
December 31, 2024 18:46
90497f3
to
0ea96d8
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_amp
branch
from
December 31, 2024 18:46
ec805a4
to
a553ee1
Compare
Draft
OwenKephart
force-pushed
the
12-23-_core-api_experimental_get_asset_provenance_
branch
from
December 31, 2024 19:18
0ea96d8
to
07509f0
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_amp
branch
from
December 31, 2024 19:18
a553ee1
to
0e35f35
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_get_asset_provenance_
branch
from
December 31, 2024 19:30
07509f0
to
7611d3a
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_amp
branch
from
December 31, 2024 19:30
0e35f35
to
3c155bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
decision: experimental -> deprecated
reason: it's deprecated, these callsites were missed earlier
docs exist: n/a
How I Tested These Changes
Changelog