Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-api][experimental] direct resource passing #26688

Open
wants to merge 1 commit into
base: 12-23-_core-api_experimental_multi_partition_mappings
Choose a base branch
from

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

decision: experimental -> public (could be convinced otherwise)
reason: this has existed for a long time, and even if it isn't directly recommended in most cases at the moment, we're moving to a world where more locally-scoped resource definitions are the norm and so this seems fair to support.
docs exist: api only

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

Copy link
Contributor Author

OwenKephart commented Dec 23, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yuhan
Copy link
Contributor

yuhan commented Dec 26, 2024

adding @dpeng817 to this one. i'm a little indifferent to GA vs not, so want second opinions here.

if we do end up making it public, i think we'll need to add docstring for resource_defs and io_manager_defs. not seeing them currently

@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_exclude_subruns branch from 85477ee to 29d9049 Compare December 31, 2024 18:47
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_direct_resource_passing branch from 6b3e956 to 19f02c5 Compare December 31, 2024 18:47
@OwenKephart OwenKephart mentioned this pull request Dec 31, 2024
@OwenKephart OwenKephart marked this pull request as ready for review December 31, 2024 18:51
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_exclude_subruns branch from 29d9049 to 8124d05 Compare December 31, 2024 19:18
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_direct_resource_passing branch from 19f02c5 to 7412f63 Compare December 31, 2024 19:19
@OwenKephart OwenKephart changed the base branch from 12-23-_core-api_experimental_exclude_subruns to 12-23-_core-api_experimental_multi_partition_mappings December 31, 2024 19:19
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_multi_partition_mappings branch from 0a1a10b to 7a9da34 Compare December 31, 2024 19:30
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_direct_resource_passing branch from 7412f63 to dc7528f Compare December 31, 2024 19:30
Copy link
Contributor

@dpeng817 dpeng817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually disagree with this.

I don't think we document direct resource passing anywhere outside of api docs, and it has known problems (specifically key collisions). There might be a few places we use it internally, but in general I think it doesn't fit with how the framework has evolved (you specify resources at the op level but assets at the spec level).

I think if we wanted to make it truly public we would at the very least need to resolve the key collisions problem (having scoped resources be a true concept within dagster) but that's unlikely to be prioritized any time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants