Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-api][experimental] AssetSelection.tag #26697

Open
wants to merge 1 commit into
base: 12-23-_core-api_experimental_table_metadata
Choose a base branch
from
Open

[core-api][experimental] AssetSelection.tag #26697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python_modules/dagster/dagster/_core/definitions/asset_selection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from typing_extensions import TypeAlias, TypeGuard

import dagster._check as check
from dagster._annotations import deprecated, experimental, experimental_param, public
from dagster._annotations import deprecated, experimental_param, public
from dagster._core.definitions.asset_check_spec import AssetCheckKey
from dagster._core.definitions.asset_graph import AssetGraph
from dagster._core.definitions.asset_key import (
Expand Down Expand Up @@ -241,7 +241,7 @@ def groups(*group_strs, include_sources: bool = False) -> "GroupsAssetSelection"

@public
@staticmethod
@experimental
@experimental_param(param="include_sources")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this experimental?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I make it not experimental upstack

def tag(key: str, value: str, include_sources: bool = False) -> "AssetSelection":
"""Returns a selection that includes materializable assets that have the provided tag, and
all the asset checks that target them.
Expand Down