-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Sorbet typed: strict
in all (non-package) files in Homebrew organisation
#17297
Comments
This comment has been minimized.
This comment has been minimized.
Follow-up work for dev-cmd and patterns to be aware of for future conversions:
|
To set expectations: this is a slow burn kind of task because if I do too much of it at once then my brain melts. But I've got some branches on the go. |
I reran Public APIs
API
Cask
Commands
Extend
Formula
Linters
Utils
Other (TODO: break these down further, or just grab a few and start)
|
For item two on the initial transition ideas list:
I have no idea how test-bot works in this case, but it sounds good. Anyone else got any ideas for approaches here? I do know that |
|
If anyone's looking to help with this (thank you), please note that |
Which taps need typing? So far I've done |
@issyl0 Great work! I think all of the taps that provide commands might be nice? Remaining ones:
|
Verification
brew install wget
. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.Provide a detailed description of the proposed feature
We should use Sorbet's
typed: strict
for all (non-package i.e. not casks or formulae) files in the Homebrew organisation.Some good transition steps will include:
typed: strict
on all new files rubocop: UseSorbet/StrictSigil
as it's better than comments #18023brew test-bot
for taps Runbrew typecheck
as part of (some)tap_syntax
tests homebrew-test-bot#1173typed: strict
in all Homebrew/brew and tap filesWhat is the motivation for the feature?
How will the feature be relevant to at least 90% of Homebrew users?
Making Homebrew more reliable.
What alternatives to the feature have been considered?
Not doing this.
The text was updated successfully, but these errors were encountered: