Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorbet: Bump more files to typed: strict #18004

Merged
merged 13 commits into from
Aug 12, 2024
Merged

sorbet: Bump more files to typed: strict #18004

merged 13 commits into from
Aug 12, 2024

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Aug 10, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Library/Homebrew/formula_auditor.rb Outdated Show resolved Hide resolved
Library/Homebrew/formula_auditor.rb Outdated Show resolved Hide resolved
Library/Homebrew/cask/audit.rb Show resolved Hide resolved
Library/Homebrew/formula_auditor.rb Outdated Show resolved Hide resolved
Library/Homebrew/readall.rb Outdated Show resolved Hide resolved
Library/Homebrew/formula_auditor.rb Outdated Show resolved Hide resolved
Co-authored-by: Bo Anderson <[email protected]>
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again @issyl0! Given how often these signatures sadly go 💥: let's hold off until after the next tag (which will be later today UK time, merge Tuesday UK time?)

@issyl0
Copy link
Member Author

issyl0 commented Aug 12, 2024

Yeah, it would be great if there was a better way of testing them but I have no idea about that apart from going through every cmd.

@MikeMcQuaid MikeMcQuaid merged commit 6105728 into master Aug 12, 2024
24 checks passed
@MikeMcQuaid MikeMcQuaid deleted the more-srb-strict branch August 12, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants