Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Sorbet typed: true #172

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Basic Sorbet typed: true #172

merged 2 commits into from
Aug 20, 2024

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Aug 19, 2024 •
edited
Loading

@issyl0
Basic Sorbet typed: true
314e699 
- In our bid to make all official taps Sorbet typed, let's do another quick one.
MikeMcQuaid
MikeMcQuaid approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Probably warrants a brew typecheck CI check before merged, either here or in test-bot, though.

@issyl0 issyl0 merged commit 5bd834a into master Aug 20, 2024
1 check passed
@issyl0 issyl0 deleted the sorbet branch August 20, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@issyl0 @MikeMcQuaid