Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Sorbet typed: true #1174

Merged
merged 6 commits into from
Aug 21, 2024
Merged

Basic Sorbet typed: true #1174

merged 6 commits into from
Aug 21, 2024

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Aug 19, 2024 •
edited
Loading

@issyl0 issyl0 changed the title Delete uses of TapFormulaWithOldnameAmbiguityError Basic Sorbet typed: true Aug 19, 2024
@issyl0 issyl0 marked this pull request as draft August 19, 2024 19:48
@issyl0 issyl0 force-pushed the inching-our-way-towards-sorbet-typed branch 3 times, most recently from fe2890c to cdc77f6 Compare August 19, 2024 20:21
@issyl0 issyl0 marked this pull request as ready for review August 19, 2024 20:28
carlocab
carlocab approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @issyl0!

Should we add running brew typecheck homebrew/test-bot to CI here?

@issyl0
Copy link
Member Author

issyl0 commented Aug 20, 2024

Yeah, see the other PR of mine in this repo (but I did that before this and haven't got back to that yet).

@MikeMcQuaid
Copy link
Member

Thanks @issyl0!

Should we add running brew typecheck homebrew/test-bot to CI here?

I think it'd be good to do this either here or in the other PR before this is merged.

Bo98
Bo98 reviewed Aug 20, 2024
View reviewed changes
lib/test_runner.rb Outdated Show resolved Hide resolved
@issyl0
Delete uses of TapFormulaWithOldnameAmbiguityError
663d3c6 
- This was removed in b717f5d9547319c2b2754d52a1fbc31f024bf2b9,
  and Sorbet rightly complained about it not existing.
@issyl0
Fewer module_functions
925360d 
- These seemed unnecessary when I ran the tests and Sorbet passes without them.
@issyl0
Make all non-test files typed: true
6875e4a
@issyl0
RBI files instead of littering include Kernel everywhere
8d51112
@issyl0 issyl0 force-pushed the inching-our-way-towards-sorbet-typed branch from e995dd9 to 8d51112 Compare August 20, 2024 19:43
@issyl0 issyl0 force-pushed the inching-our-way-towards-sorbet-typed branch from 0b8ca84 to be6b135 Compare August 20, 2024 19:55
carlocab
carlocab reviewed Aug 21, 2024
View reviewed changes
lib/tests/formulae_detect.rb Outdated Show resolved Hide resolved
lib/tests/formulae_detect.rb Outdated Show resolved Hide resolved
MikeMcQuaid
MikeMcQuaid approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once @carlocab's comment addressed!

@issyl0 @carlocab
Update formulae_detect.rb
18f5833 
Co-authored-by: Carlo Cabrera <[email protected]>
@MikeMcQuaid MikeMcQuaid merged commit 3bd03ee into master Aug 21, 2024
4 checks passed
@MikeMcQuaid MikeMcQuaid deleted the inching-our-way-towards-sorbet-typed branch August 21, 2024 09:11
@MikeMcQuaid
Copy link
Member

Thanks again @issyl0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bo98 Bo98 Bo98 left review comments

@carlocab carlocab carlocab approved these changes

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@issyl0 @MikeMcQuaid @Bo98 @carlocab