Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Sorbet typed: true #1174

Merged
merged 6 commits into from
Aug 21, 2024
Merged

Basic Sorbet typed: true #1174

merged 6 commits into from
Aug 21, 2024
+62 −29

Commits on Aug 20, 2024

  1. Delete uses of TapFormulaWithOldnameAmbiguityError 

    - This was removed in b717f5d9547319c2b2754d52a1fbc31f024bf2b9,
  and Sorbet rightly complained about it not existing.
    @issyl0
    issyl0 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    663d3c6 View commit details
    Browse the repository at this point in the history

  2. Fewer module_functions 

    - These seemed unnecessary when I ran the tests and Sorbet passes without them.
    @issyl0
    issyl0 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    925360d View commit details
    Browse the repository at this point in the history

  3. Make all non-test files typed: true

    @issyl0
    issyl0 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    6875e4a View commit details
    Browse the repository at this point in the history

  4. RBI files instead of littering include Kernel everywhere

    @issyl0
    issyl0 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    8d51112 View commit details
    Browse the repository at this point in the history

  5. Fix retrieving pr from a Regexp

    @issyl0
    issyl0 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    be6b135 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Update formulae_detect.rb 

    Co-authored-by: Carlo Cabrera <[email protected]>
    @issyl0 @carlocab
    issyl0 and carlocab committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    18f5833 View commit details
    Browse the repository at this point in the history