Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sorbet: Tighten up dev-cmd types #17625

Merged
merged 2 commits into from
Jul 4, 2024
Merged

sorbet: Tighten up dev-cmd types #17625

merged 2 commits into from
Jul 4, 2024

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Jul 4, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@issyl0
sorbet: Tighten up dev-cmd types
f2f4f1c 
- Change `returns(NilClass)` to `void`.
- Get rid of some of the `T.untyped`.
@issyl0 issyl0 force-pushed the more-sorbet-strict-devcmd branch from df41ae7 to f2f4f1c Compare July 4, 2024 11:04
@issyl0 issyl0 enabled auto-merge July 4, 2024 11:46
MikeMcQuaid
MikeMcQuaid approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks again @issyl0!

Library/Homebrew/dev-cmd/update-sponsors.rb Outdated Show resolved Hide resolved
@issyl0 @MikeMcQuaid
Remove unnecessary comment
f6e093a 
- `T.let` is necessary in this case in strict mode.

Co-authored-by: Mike McQuaid <[email protected]>
@issyl0 issyl0 merged commit e1fe3e2 into master Jul 4, 2024
25 checks passed
@issyl0 issyl0 deleted the more-sorbet-strict-devcmd branch July 4, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@issyl0 @MikeMcQuaid