Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sorbet: Tighten up dev-cmd types #17625

Merged
merged 2 commits into from
Jul 4, 2024
Merged

sorbet: Tighten up dev-cmd types #17625

merged 2 commits into from
Jul 4, 2024

Commits on Jul 4, 2024

  1. sorbet: Tighten up dev-cmd types 

    - Change `returns(NilClass)` to `void`.
- Get rid of some of the `T.untyped`.
    @issyl0
    issyl0 committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    f2f4f1c View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary comment 

    - `T.let` is necessary in this case in strict mode.

Co-authored-by: Mike McQuaid <[email protected]>
    @issyl0 @MikeMcQuaid
    issyl0 and MikeMcQuaid committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    f6e093a View commit details
    Browse the repository at this point in the history