enable typed: strict in Homebrew::CLI::Args
#18083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocab
approved these changes
Aug 19, 2024
MikeMcQuaid
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Looks good thanks @dduugg! Will hold off merging until after next tag 🔜 today.
Bo98
approved these changes
Aug 19, 2024
dduugg
changed the title
typed: strict Homebrew::CLI::Argstyped: strict in Homebrew::CLI::Args
carlocab
approved these changes
Aug 20, 2024
carlocab
reviewed
Aug 20, 2024
| @@ -165,10 +186,12 @@ def cli_args | |||
| @cli_args.freeze | |||
| end | |||
|
|
|||
| def respond_to_missing?(method_name, *) | |||
| sig { params(method_name: Symbol, _include_private: T::Boolean).returns(T::Boolean) } | |||
| def respond_to_missing?(method_name, _include_private = false) | |||
There was a problem hiding this comment.
Not sure why it didn't error here, but it's now erroring on master:
https://github.com/Homebrew/brew/actions/runs/10469292764/job/28991992536#step:7:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Part of #17297
Also helpful as I hack at removing the
OpenStructdependency