sorbet: Comment more files that can't be strict because of undef

[issyl0]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

• Part of Use Sorbet typed: strict in all (non-package) files in Homebrew organisation #17297.
• Found with grep -rL "# typed: strict" Library/Homebrew | xargs grep -l "undef ".
• This stops people from trying to bump them and getting an error that they can't fix because it's a Sorbet limitation, wasting contributor time.

[carlocab]

I suspect many (if not all) of these undefs can be removed, so it may still be possible to make these typed: strict

[issyl0]

Oooh, in that case, sounds like we should write another issue to investigate removing them?

[carlocab]

Oooh, in that case, sounds like we should write another issue to investigate removing them?

Yep, fine to merge if we have an issue like that.

[MikeMcQuaid]

Would be nice if there was a wait for a response to "Are all of the undefs we use really necessary?" before we went "yes, let's remove a bunch" 😉

[issyl0]

This PR doesn't remove a bunch, it just notes that we can't Sorbet strict these files.

The issue doesn't remove any either, just lays the groundwork with where they exist, and invites someone to answer the question.

I don't think at any point we said "yes let's remove them"?

[MikeMcQuaid]

This PR doesn't remove a bunch, it just notes that we can't Sorbet strict these files.

Doh, I'm sorry 🤦🏻. Misread. Idiot, apologies!