Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more files Sorbet typed: strict #17410

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Jun 2, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?


diff --git a/Library/Homebrew/dev-cmd/typecheck.rb b/Library/Homebrew/dev-cmd/typecheck.rb
index 46fa968a0a..16f3c11fb1 100644
--- a/Library/Homebrew/dev-cmd/typecheck.rb
+++ b/Library/Homebrew/dev-cmd/typecheck.rb
@@ -60,7 +60,7 @@ module Homebrew
             if args.suggest_typed?
               ohai "Bumping Sorbet `typed` sigils..."
               # --sorbet needed because of https://github.com/Shopify/spoom/issues/488
-              safe_system "bundle", "exec", "spoom", "srb", "bump", "--dry", "--sorbet",
+              safe_system "bundle", "exec", "spoom", "srb", "bump", "--from", "true", "--to", "strict", "--sorbet",
                           "#{Gem.bin_path("sorbet", "srb")} tc"
             end

- According to Spoom, these could be bumped automatically with no errors.
@issyl0 issyl0 enabled auto-merge June 2, 2024 14:34
@issyl0 issyl0 merged commit fb81a6d into master Jun 2, 2024
26 checks passed
@issyl0 issyl0 deleted the more-sorbet-typed-strict branch June 2, 2024 14:47
@MikeMcQuaid
Copy link
Member

Thanks @issyl0!

  • According to Spoom (see below), these could be bumped automatically with no errors.

Might be worth automating this! Could be part of the existing Sorbet workflow.

@github-actions github-actions bot added the outdated PR was locked due to age label Jul 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants