Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make brew typecheck --update --suggest-typed bump strictness further #17411

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Jun 2, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

- Not only `false` to `true` but `true` to `strict`.
- Only humans every run this, but our goal is to increase the
  typechecking in our files to get to `strict` everywhere so
  let's make that easy to remember to do.
Copy link
Contributor

@apainintheneck apainintheneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good and works for me locally.

My only nit is that the brew type check --update --suggest-typed exits with a non-zero exit code when there are files that can be bumped up a strictness level. It seems like it should still exit successfully since this is only a suggestion.

Error: Failure while executing; `bundle exec spoom srb bump --dry --from true --to strict --sorbet /usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/sorbet-0.5.11406/bin/srb\ tc` exited with 1.

@issyl0 issyl0 merged commit e130e47 into master Jun 2, 2024
26 checks passed
@issyl0 issyl0 deleted the typecheck-spoom-better branch June 2, 2024 21:56
@MikeMcQuaid
Copy link
Member

Thanks @issyl0!

My only nit is that the brew type check --update --suggest-typed exits with a non-zero exit code when there are files that can be bumped up a strictness level. It seems like it should still exit successfully since this is only a suggestion.

I think with --update supplied it should do the bumping for us automatically.

@apainintheneck
Copy link
Contributor

Yeah, if that's possible, that would be great.

@issyl0
Copy link
Member Author

issyl0 commented Jun 4, 2024

Yeah, removing --dry should do it.

@MikeMcQuaid
Copy link
Member

Ok, think this is working as expected then, thanks @issyl0!

@github-actions github-actions bot added the outdated PR was locked due to age label Jul 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants