Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend/os/linux/formula_installer: use typed: strict #18045

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

p-linnane
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Part of #17297.

@issyl0
Copy link
Member

issyl0 commented Aug 13, 2024

Ah, sorry! I should have explained and not assume you saw the PR yesterday where I switched these over. The point of rubocop:disable here (as opposed to :todo) is that these are not typecheckable because they use undef.

Unless you can confidently answer #17998 for this undef, it's better for now to focus on the rubocop:todos.

@p-linnane p-linnane closed this Aug 13, 2024
@p-linnane p-linnane deleted the linux-formula_installer-strict branch August 13, 2024 22:08
@carlocab carlocab restored the linux-formula_installer-strict branch August 15, 2024 08:55
@carlocab carlocab reopened this Aug 15, 2024
@carlocab
Copy link
Member

Yea, let's do this now: #17998 (comment)

@carlocab carlocab merged commit c42860c into master Aug 15, 2024
47 checks passed
@carlocab carlocab deleted the linux-formula_installer-strict branch August 15, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants