Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab Switcher Animation: Ship Review Changes #5783

Open
wants to merge 13 commits into
base: feature/mike/tab-switcher-tile-animation/add-animated-tile-placeholder
Choose a base branch
from
Open

Tab Switcher Animation: Ship Review Changes #5783

wants to merge 13 commits into from
+311 −556

Conversation

mikescamell
Copy link
Contributor

@mikescamell mikescamell commented Mar 17, 2025 •
edited by 0nko
Loading

Task/Issue URL: https://app.asana.com/1/137249556945/project/1207908166761516/task/1209668387604470

Description

Refactored the tracker animation tile in the tab switcher to use a common InfoPanel component, improving code reuse and maintainability. The animation tile now appears as a single panel that spans the full width of the grid layout, providing a more consistent UI experience.

Steps to test this PR

Designs

Ensure tabSwitcherAnimation is turned on in Feature Flag inventory

Tab Switcher Tracker Animation Panel

  • Open the tab switcher and verify the tracker animation panel appears at the top
  • Verify the panel shows the correct tracker count for the last 7 days
  • Tap on the panel to open a dialog
  • Dismiss the dialog via the "Got it" button
  • Tap on the panel to open the dialog again
  • Click "Hide Banner"
  • Verify the info panel is gone
  • Close the app
  • Open the app
  • Verify the info panel is still gone
  • In developer settings, reset the animation tile dismissal and verify it reappears
  • Verify the panel works correctly in both grid and list views

Data Clearing

  • Open some websites and build up a tracker count in the info panel
  • Clear data via the fire button
  • Verify the tracker count is now 0 in the info panel
  • Open some websites and build up a tracker count in the info panel again
  • In Settings set automatic data clearing to on exit
  • Close the app via recents
  • Open the app
  • Verify the tracker count is now 0 in the info panel

Demo

Screen_recording_20250318_152707.mp4

This was referenced Mar 17, 2025
Open
Merged
Merged
Merged
@mikescamell Graphite App
Copy link
Contributor Author

mikescamell commented Mar 17, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Base automatically changed from feature/mike/tab-switcher-tile-animation/add-show-hide-logic to feature/mike/tab-switcher-tile-animation/translations March 17, 2025 17:56
Base automatically changed from feature/mike/tab-switcher-tile-animation/translations to feature/mike/tab-switcher-tile-animation/display-real-tracker-count March 17, 2025 18:18
Base automatically changed from feature/mike/tab-switcher-tile-animation/display-real-tracker-count to feature/mike/tab-switcher-tile-animation/add-animated-tile-placeholder March 18, 2025 09:11
@mikescamell mikescamell force-pushed the feature/mike/tab-switcher-tile-animation/ship-review-changes branch from 0cd290e to cfa9e25 Compare March 18, 2025 09:36
@mikescamell mikescamell mentioned this pull request Mar 18, 2025
Open
3 tasks
@mikescamell mikescamell force-pushed the feature/mike/tab-switcher-tile-animation/ship-review-changes branch 3 times, most recently from 0b3434b to adbca09 Compare March 18, 2025 16:36
@mikescamell mikescamell changed the base branch from feature/mike/tab-switcher-tile-animation/add-animated-tile-placeholder to graphite-base/5783 March 19, 2025 15:10
@mikescamell mikescamell force-pushed the feature/mike/tab-switcher-tile-animation/ship-review-changes branch from adbca09 to c1eeb48 Compare March 19, 2025 17:31
@mikescamell mikescamell changed the base branch from graphite-base/5783 to feature/mike/tab-switcher-tile-animation/add-animated-tile-placeholder March 19, 2025 17:32
@mikescamell mikescamell marked this pull request as ready for review March 19, 2025 17:34
@mikescamell mikescamell requested a review from 0nko March 19, 2025 17:34
@mikescamell mikescamell changed the base branch from feature/mike/tab-switcher-tile-animation/add-animated-tile-placeholder to graphite-base/5783 March 19, 2025 17:53
@mikescamell mikescamell force-pushed the feature/mike/tab-switcher-tile-animation/ship-review-changes branch from c1eeb48 to 9fed8f6 Compare March 19, 2025 17:54
@mikescamell mikescamell changed the base branch from graphite-base/5783 to feature/mike/tab-switcher-tile-animation/add-animated-tile-placeholder March 19, 2025 17:54
@mikescamell mikescamell force-pushed the feature/mike/tab-switcher-tile-animation/ship-review-changes branch from 9fed8f6 to 2f54c98 Compare March 20, 2025 09:48
@mikescamell mikescamell force-pushed the feature/mike/tab-switcher-tile-animation/add-animated-tile-placeholder branch from 312cac5 to 2c2c312 Compare March 20, 2025 09:48
@mikescamell mikescamell mentioned this pull request Mar 20, 2025
Open
4 tasks
@0nko 0nko self-assigned this Mar 20, 2025
0nko
0nko approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works as expected! 🎖️

@mikescamell mikescamell force-pushed the feature/mike/tab-switcher-tile-animation/add-animated-tile-placeholder branch from 2c2c312 to e8f77e6 Compare March 20, 2025 13:45
@mikescamell mikescamell force-pushed the feature/mike/tab-switcher-tile-animation/ship-review-changes branch from f33efe5 to e3f5a7c Compare March 20, 2025 13:45
@mikescamell
Refactor: Remove TabSwitcherTileAnimationMonitor
d1d6d8f 
The `TabSwitcherTileAnimationMonitor` and its associated tests have been removed.
The logic to observe the animation tile visibility has been moved to the `TabSwitcherDataStore` to improve code organization.
The `TabSwitcherViewModel` now directly interacts with the `TabSwitcherDataStore`.
Also, the animation tile seen state is removed from `TabSwitcherDataStore`, the tile will be shown until is dismissed.
When clearing personal data, the animation tile will not be reset anymore.
Finally, the action to reset the animation tile has been updated in the dev settings.
@mikescamell
Switch to using InfoPanel style for the tracker animation
a557aa3 
It's the same view in both grid and list so we don't need two variations anymore.

I'm using a custom layout as adding the animation would have required a lot of hacky changes to the original InfoPanel. I'd rather look into that more in future if the experiment succeeds.

Renaming the item in the next commit
@mikescamell
Rename to TrackerAnimationInfoPanel
0404b7f
@mikescamell
Add custom GridLayoutManager with span size lookup for TrackerAnimati…
71ea7e4 
…onInfoPanel
@mikescamell
Add animated tile dismissal dialog to TabSwitcher
3fad4c4 
We want to show a dialog when the user taps the info panel, and explain what the panel is doing but allow the user to hide it if they really want to
@mikescamell
Add deleteAll method to WebTrackersBlockedDao and repository
35bdde1
@mikescamell
Add WebTrackersBlockedRepository to ClearPersonalDataAction for data …
ded151f 
…clearing

We did this every 7 days via a worker but we want to do this now if a user uses the fire button or has automatic data clearing on
@mikescamell
Fix tests
20cbc17
@mikescamell
Remove multiple returns
3d9026f
@mikescamell
Suppress invalid color attribute
c733ac6 
The animation text is black in both light and dark mode
@mikescamell
Add new tests
0d1db77
@mikescamell
Fix verification of WebTrackersBlockedRepository deletion in tests
68e7c1e
@mikescamell
Use new shield animation
f31f09f
@mikescamell mikescamell force-pushed the feature/mike/tab-switcher-tile-animation/ship-review-changes branch from 87266ae to f31f09f Compare March 21, 2025 08:55
@mikescamell mikescamell force-pushed the feature/mike/tab-switcher-tile-animation/add-animated-tile-placeholder branch from e8f77e6 to 9642812 Compare March 21, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0nko 0nko

@malmstein malmstein

@nalcalag nalcalag

Assignees

@0nko 0nko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikescamell @0nko