Tab Switcher Animation: Add pixels #5802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. |
20 tasks
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/add-pixels
branch
from
0790f4f to
c37b211
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/ship-review-translations
branch
2 times, most recently
from
6e965af to
f38c857
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/add-pixels
branch
2 times, most recently
from
7924095 to
903e299
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/ship-review-translations
branch
from
ff0442f to
eb5a0b1
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/add-pixels
branch
from
903e299 to
e49f8ac
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/add-pixels
branch
from
e49f8ac to
40ecf02
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/ship-review-translations
branch
from
eb5a0b1 to
8d2e53e
Compare
- Add an `OnScrollListener` to the tabs recycler view to detect when the tracker animation panel is sufficiently visible. - Introduce a `isTrackerAnimationPanelVisible` flag to prevent repeated visibility notifications. - Trigger `onTrackerAnimationInfoPanelVisible` when the panel is more than 75% visible and was not previously considered visible. - Reset `isTrackerAnimationPanelVisible` when the panel is not sufficiently visible. - Add `onScrollCompleted` callback to `scrollToActiveTab` and `scrollToPosition` functions to ensure `addOnScrollListener` is only called after the initial scroll is completed. - Only add `OnScrollListener` when the we have the layout set - Stop listening for scroll updates as soon as a user changes layout type so we don't send pixels while changing layouts
We don't allow deleting the animation unless you go via the dialog
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/add-pixels
branch
from
40ecf02 to
fe8fa06
Compare
0nko
approved these changes
Mar 21, 2025
mikescamell
merged commit c0dd08f
into
feature/mike/tab-switcher-tile-animation/ship-review-translations
5 of 6 checks passed
mikescamell
deleted the
feature/mike/tab-switcher-tile-animation/add-pixels
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207908166761516/1209726015931612/f
Description
Added tracking for the tab manager info panel with three new pixels:
m_tab_manager_info_panel_impressions- Fired when the panel becomes visiblem_tab_manager_info_panel_dismissed- Fired when the panel is dismissed, includes tracker countm_tab_manager_info_panel_tapped- Fired when the panel is tappedImplemented visibility detection for the tracker animation info panel in the tab switcher to accurately track impressions.
Steps to test this PR
Pre-requisite: Enable
tabSwitcherAnimationfeature flagm_tab_manager_info_panel_impressions
m_tab_manager_info_panel_impressionsfiresm_tab_manager_info_panel_impressionsis not firedm_tab_manager_info_panel_impressionsis not firedm_tab_manager_info_panel_impressionsis firedm_tab_manager_info_panel_impressionsis firedm_tab_manager_info_panel_impressionsis not firedm_tab_manager_info_panel_tapped
m_tab_manager_info_panel_dismissed
UI changes
N/A