Tab Switcher Animation: Ship Review Change Translations #5786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. |
mikescamell
changed the base branch from
feature/mike/tab-switcher-tile-animation/ship-review-changes
to
graphite-base/5786
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/ship-review-translations
branch
from
458aa5e to
fc95edf
Compare
mikescamell
force-pushed
the
graphite-base/5786
branch
from
cfa9e25 to
f18ba86
Compare
mikescamell
changed the base branch from
graphite-base/5786
to
feature/mike/tab-switcher-tile-animation/ship-review-changes
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/ship-review-translations
branch
from
fc95edf to
9542c96
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/ship-review-changes
branch
from
f18ba86 to
969bed2
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/ship-review-translations
branch
from
9542c96 to
740d9cf
Compare
mikescamell
changed the base branch from
feature/mike/tab-switcher-tile-animation/ship-review-changes
to
graphite-base/5786
mikescamell
force-pushed
the
graphite-base/5786
branch
from
0b3434b to
2f54c98
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/ship-review-translations
branch
from
cdb792b to
231f7a0
Compare
mikescamell
changed the base branch from
graphite-base/5786
to
feature/mike/tab-switcher-tile-animation/ship-review-changes
21 tasks
mikescamell
changed the base branch from
feature/mike/tab-switcher-tile-animation/ship-review-changes
to
graphite-base/5786
mikescamell
force-pushed
the
graphite-base/5786
branch
from
2f54c98 to
e3f5a7c
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/ship-review-translations
branch
from
231f7a0 to
6e965af
Compare
mikescamell
changed the base branch from
graphite-base/5786
to
feature/mike/tab-switcher-tile-animation/ship-review-changes
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/ship-review-translations
branch
from
6e965af to
f38c857
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/ship-review-changes
branch
from
87266ae to
f31f09f
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/ship-review-translations
branch
from
ff0442f to
eb5a0b1
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/ship-review-translations
branch
from
eb5a0b1 to
8d2e53e
Compare
Task/Issue URL: https://app.asana.com/0/1207908166761516/1209726015931612/f ### Description Added tracking for the tab manager info panel with three new pixels: - `m_tab_manager_info_panel_impressions` - Fired when the panel becomes visible - `m_tab_manager_info_panel_dismissed` - Fired when the panel is dismissed, includes tracker count - `m_tab_manager_info_panel_tapped` - Fired when the panel is tapped Implemented visibility detection for the tracker animation info panel in the tab switcher to accurately track impressions. ### Steps to test this PR Pre-requisite: Enable `tabSwitcherAnimation` feature flag _m_tab_manager_info_panel_impressions_ - [x] Start with no tabs - [x] Open the TabSwitcher - [x] Verify `m_tab_manager_info_panel_impressions` fires - [x] Add many tabs (use developer settings to easily add 100) - [x] Ensure that the active tab is one where you cannot see the animated info panel - [x] Close the TabSwitcher - [x] Open the TabSwitcher - [x] Ensure that `m_tab_manager_info_panel_impressions` is **not** fired - [x] Scroll up slowly to the animated tile until the bottom of the info panel is barely visible - [x] Ensure that `m_tab_manager_info_panel_impressions` is **not** fired - [x] Scroll up until ~75% of the tile is visible - [x] Ensure that `m_tab_manager_info_panel_impressions` **is** fired - [x] Scroll away from the InfoPanel until it is not visible - [x] Scroll back to the InfoPanel - [x] Ensure that `m_tab_manager_info_panel_impressions` **is** fired - [x] Scroll away from the InfoPanel until it is not visible - [x] Switch layouts - [x] Ensure that `m_tab_manager_info_panel_impressions` is **not** fired _m_tab_manager_info_panel_tapped_ - [x] Open the TabSwitcher - [x] Tap on the panel and verify the tapped pixel is fired _m_tab_manager_info_panel_dismissed_ - [x] Dismiss the panel and verify the dismissed pixel is fired with tracker count ### UI changes N/A
mikescamell
merged commit f8d50af
into
feature/mike/tab-switcher-tile-animation/ship-review-changes
4 of 5 checks passed
mikescamell
deleted the
feature/mike/tab-switcher-tile-animation/ship-review-translations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1209710789450014/f
Description
Moved TabSwitcher Animation Tile Dialog string resources from
donottranslate.xmltostrings.xmlto enable translation of these user-facing messages.Steps to test this PR
TabSwitcher Animation Tile Dialog
UI changes
N/A