Tab Switcher Animation: Add real tracker count #5723
Merged
+712
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9 tasks
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/add-animated-tile-placeholder
branch
from
a4c9e80 to
6150c8f
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/display-real-tracker-count
branch
from
6dbb1d4 to
753e562
Compare
mikescamell
changed the base branch from
feature/mike/tab-switcher-tile-animation/add-animated-tile-placeholder
to
graphite-base/5723
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/display-real-tracker-count
branch
from
753e562 to
f4309c1
Compare
mikescamell
changed the base branch from
graphite-base/5723
to
feature/mike/tab-switcher-tile-animation/add-animated-tile-placeholder
5 tasks
mikescamell
changed the title
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/display-real-tracker-count
branch
from
f4309c1 to
c5263f4
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/add-animated-tile-placeholder
branch
from
e4fd0fa to
2e13d0c
Compare
43 tasks
mikescamell
changed the base branch from
feature/mike/tab-switcher-tile-animation/add-animated-tile-placeholder
to
graphite-base/5723
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/display-real-tracker-count
branch
from
c5263f4 to
b005223
Compare
mikescamell
force-pushed
the
graphite-base/5723
branch
from
2e13d0c to
f8fd101
Compare
mikescamell
changed the base branch from
graphite-base/5723
to
feature/mike/tab-switcher-tile-animation/add-animated-tile-placeholder
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/display-real-tracker-count
branch
from
b005223 to
4fe8ab9
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/add-animated-tile-placeholder
branch
from
f8fd101 to
0f66c87
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/display-real-tracker-count
branch
from
1fcf730 to
aab5219
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/add-animated-tile-placeholder
branch
from
0f66c87 to
bf31d11
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/display-real-tracker-count
branch
from
aab5219 to
8aa0824
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/add-animated-tile-placeholder
branch
from
bf31d11 to
392f190
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/display-real-tracker-count
branch
from
8aa0824 to
f2828b6
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/add-animated-tile-placeholder
branch
from
392f190 to
3cae589
Compare
… and WebTrackersBlockedDao Not adding the public API yet as it's an experiment and there's a chance we kill it
This commit refactors the Tab Switcher to display the tracker animation tile with the actual tracker count. * The `TabSwitcherViewModel` now uses `liveData` instead of `map` to emit the list of `TabSwitcherItem`. * The `TabSwitcherViewModel` now uses a `switchMap` operator to emit the `tabSwitcherItems` live data which allows us to call the getTrackersCountBetween suspending function * The `TabSwitcherViewModel` now creates the tracker animation tile using the real number of trackers blocked in the last 7 days, retrieved using the `WebTrackersBlockedAppRepository`. * The `TabSwitcherAdapter` now takes the actual tracker count from the `TabSwitcherItem.TrackerAnimationTile` to show in the view. * Removed the random tracker count generation from the adapter.
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/add-animated-tile-placeholder
branch
from
3cae589 to
640be9c
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/display-real-tracker-count
branch
from
f2828b6 to
bf8dd2b
Compare
20 tasks
Task/Issue URL: https://app.asana.com/0/1207908166761516/1209560463368002 ### Description Added localized strings for tracker blocking statistics animation in the tab switcher across multiple languages. The strings display the number of trackers blocked in the last 7 days. ### Steps to test this PR _Verify translations_ - [x] Switch device language to different supported locales and verify the tracker blocking statistics text appears correctly - [x] Verify placeholder formatting works correctly with different numeric values - [x] Check that HTML formatting (bold tags) renders properly across languages _Verify string usage_ - [x] Open tab switcher and confirm tracker blocking statistics are displayed - [x] Verify the "in the last 7 days" text appears correctly below the main statistics --------- Co-authored-by: Dax The Translator <[email protected]>
mikescamell
merged commit f14cf7d
into
feature/mike/tab-switcher-tile-animation/add-animated-tile-placeholder
4 of 5 checks passed
mikescamell
deleted the
feature/mike/tab-switcher-tile-animation/display-real-tracker-count
branch
3 tasks
mikescamell
added a commit
that referenced
this pull request
Mar 19, 2025
Task/Issue URL: https://app.asana.com/0/488551667048375/1209368500700765 Replaced random tracker count with actual tracker data from the past 7 days in the tab switcher animation tile. The tracker count is now fetched from the WebTrackersBlockedAppRepository instead of generating random numbers. _Tab Switcher Tracker Count_ - [x] Open the tab switcher - [x] Verify the tracker count shown matches the actual number of trackers blocked in the last 7 days - [x] Verify the tracker animation tile displays correctly in both grid and list views (Tablet omitted as only count has changed) https://github.com/user-attachments/assets/044501d7-a61f-478c-b0ea-19e59ac35049 --------- Co-authored-by: Dax The Translator <[email protected]>
21 tasks
mikescamell
added a commit
that referenced
this pull request
Mar 21, 2025
Task/Issue URL: https://app.asana.com/0/488551667048375/1209368500700765 Replaced random tracker count with actual tracker data from the past 7 days in the tab switcher animation tile. The tracker count is now fetched from the WebTrackersBlockedAppRepository instead of generating random numbers. _Tab Switcher Tracker Count_ - [x] Open the tab switcher - [x] Verify the tracker count shown matches the actual number of trackers blocked in the last 7 days - [x] Verify the tracker animation tile displays correctly in both grid and list views (Tablet omitted as only count has changed) https://github.com/user-attachments/assets/044501d7-a61f-478c-b0ea-19e59ac35049 --------- Co-authored-by: Dax The Translator <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1209368500700765
Description
Replaced random tracker count with actual tracker data from the past 7 days in the tab switcher animation tile. The tracker count is now fetched from the WebTrackersBlockedAppRepository instead of generating random numbers.
Steps to test this PR
Tab Switcher Tracker Count
Demo
(Tablet omitted as only count has changed)
Screen_recording_20250303_180553.mp4