Tab Switcher Animation: Translations #5724
Merged
+663
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
mikescamell
changed the title
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/translations
branch
from
c60974a to
fa5ceaf
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/display-real-tracker-count
branch
from
f4309c1 to
c5263f4
Compare
43 tasks
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/display-real-tracker-count
branch
from
c5263f4 to
b005223
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/translations
branch
2 times, most recently
from
6b63d29 to
a5c2d0d
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/display-real-tracker-count
branch
from
b005223 to
4fe8ab9
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/translations
branch
from
a5c2d0d to
faeee79
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/translations
branch
from
da791c6 to
4196975
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/display-real-tracker-count
branch
from
1fcf730 to
aab5219
Compare
mikescamell
commented
Mar 11, 2025
Comment on lines
+87
to
+88
| val formattedTrackerCount = trackerCountNumberFormatter.format(trackerCount) | ||
| val text = context.getString(stringRes, formattedTrackerCount) |
There was a problem hiding this comment.
@0nko We're adding a change to format the string based on Locale, e.g. 1000 becomes 1,000
I added it here so we can get all the properly translated strings
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/display-real-tracker-count
branch
from
aab5219 to
8aa0824
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/translations
branch
2 times, most recently
from
ee7bb0e to
a66cf46
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/display-real-tracker-count
branch
from
8aa0824 to
f2828b6
Compare
Translate strings to values-sk
Translate strings to values-bg
We want to add commas or whatever is appropriate to the number for cases where it goes to 1,000 and above
Translate strings to values-es Translate strings to values-ro Translate strings to values-tr Translate strings to values-sk Translate strings to values-ru Translate strings to values-et Translate strings to values-it Translate strings to values-pl Translate strings to values-bg Translate strings to values-lv Translate strings to values-fi Translate strings to values-sl Translate strings to values-nl Translate strings to values-hr Translate strings to values-hu Translate strings to values-nb Translate strings to values-sv Translate strings to values-da Translate strings to values-el Translate strings to values-fr Translate strings to values-lt Translate strings to values-pt Translate strings to values-cs
Translate strings to values-cs
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/display-real-tracker-count
branch
from
f2828b6 to
bf8dd2b
Compare
mikescamell
force-pushed
the
feature/mike/tab-switcher-tile-animation/translations
branch
from
52a92a5 to
406b808
Compare
20 tasks
Translate strings to values-es Translate strings to values-ro Translate strings to values-tr Translate strings to values-sk Translate strings to values-ru Translate strings to values-et Translate strings to values-it Translate strings to values-pl Translate strings to values-bg Translate strings to values-lv Translate strings to values-fi Translate strings to values-sl Translate strings to values-nl Translate strings to values-hr Translate strings to values-hu Translate strings to values-nb Translate strings to values-sv Translate strings to values-da Translate strings to values-el Translate strings to values-fr Translate strings to values-lt Translate strings to values-pt Translate strings to values-cs
Task/Issue URL: https://app.asana.com/0/1207908166761516/1209368500700767 ### Description Added show/hide logic for the animated tile. The tile appears when users have blocked at least 10 trackers and have 2 or more tabs open. Once visible the tile does not get removed unless: - The user dismisses it - The user clears data either manually or automatically through data clearing settings Once dismissed, the tile will not reappear until explicitly re-enabled or reset through dev settings. ### Steps to test this PR Pre-requisites: `tabSwitcherAnimation` feature toggle is turned on _Tab Switcher Animated Tile Showing_ - [x] Open the TabSwitcher - [x] The animated tile should not should be visible - [x] Open a website in the new tab (bbc.com for example) - [x] Add another tab and open another website (cnn.com for example) - [x] Open the TabSwitcher - [x] The Animation Tile should be visible - [x] If it's not visible it is probably because you do not have enough trackers. Open another website in either one of the tabs (ign.com for example) - [x] The Animation Tile should now be visible and display the tracker count _Tab Switcher Animated Tile Stays Visible Once Seen_ - [x] Delete one of the tabs - [x] The animated tile should still be visible - [x] Leave the Tab Switcher - [x] Re-enter - [x] The animated tile should still be visible _Tab Switcher Animated Tile Dismissal_ - [x] Dismiss the animated tile - [x] Leave the Tab Switcher - [x] Re-enter - [x] The animated tile should not be visible _Tab Switcher Animated Tile Clearing Data_ - [x] Go to Dev Settings - [x] Click "Reset TabSwitcher Animated Tile" - [x] Open the TabSwitcher - [x] Open a new tab and load a website - [x] Go back to the TabSwitcher - [x] The animated tile should be visible - [x] Open Settings - [x] Open Data Clearing - [x] Click "Automatically Clear Data" - [x] Select "App exit only" - [x] Leave Settings - [x] Exit the app - [x] Swipe the app away from recents - [x] Open the app - [x] Open the Tab Switcher - [x] The animated tile and all tabs should no longer exist _Tab Switcher Animated Tile Show Again After Clearing Data_ - [x] Repeat steps for _Tab Switcher Animated Tile Showing_ - [x] Animated tile should show again _Tab Switcher Animated Tile Close All Tabs_ - [x] Open the TabSwitcher - [x] The animated tile should be visible - [x] Press the overflow menu button - [x] Click "Close All Tabs" - [x] Click "Close" in the dialog - [x] The animated tile and all tabs should no longer exist _Tab Switcher Animated Tile Show Again After Close Tabs_ - [x] Repeat steps for _Tab Switcher Animated Tile Showing_ - [x] Animated tile should show again ### Demo https://github.com/user-attachments/assets/2652888b-80fa-45de-b3df-10d59eb54e29
mikescamell
merged commit 9787f01
into
feature/mike/tab-switcher-tile-animation/display-real-tracker-count
4 of 5 checks passed
mikescamell
deleted the
feature/mike/tab-switcher-tile-animation/translations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207908166761516/1209560463368002
Description
Added localized strings for tracker blocking statistics animation in the tab switcher across multiple languages. The strings display the number of trackers blocked in the last 7 days.
Steps to test this PR
Verify translations
Verify string usage