Format tracker count based on Locale

We want to add commas or whatever is appropriate to the number for cases where it goes to 1,000 and above

Author: mikescamell

app/src/main/java/com/duckduckgo/app/tabs/ui/TrackerCountAnimator.kt

@@ -23,6 +23,7 @@ import android.view.animation.AccelerateDecelerateInterpolator
 import android.widget.TextView
 import androidx.annotation.StringRes
 import androidx.core.text.HtmlCompat
+import java.text.NumberFormat
 import javax.inject.Inject
 import kotlin.math.roundToInt
 import kotlin.time.Duration.Companion.seconds
@@ -39,6 +40,7 @@ class TrackerCountAnimator @Inject constructor() {
     @StringRes private var stringRes: Int? = null
     private var trackerTextView: TextView? = null
     private lateinit var context: Context
+    private val trackerCountNumberFormatter by lazy(LazyThreadSafetyMode.NONE) { NumberFormat.getNumberInstance() }
 
     private val animator = ValueAnimator().apply {
         interpolator = AccelerateDecelerateInterpolator()
@@ -82,7 +84,8 @@ class TrackerCountAnimator @Inject constructor() {
     }
 
     private fun getFormattedText(context: Context, @StringRes stringRes: Int, trackerCount: Int): Spanned {
-        val text = context.getString(stringRes, trackerCount)
+        val formattedTrackerCount = trackerCountNumberFormatter.format(trackerCount)
+        val text = context.getString(stringRes, formattedTrackerCount)
         return HtmlCompat.fromHtml(text, HtmlCompat.FROM_HTML_MODE_LEGACY)
     }
 }

app/src/main/res/values/strings.xml

@@ -114,8 +114,8 @@
     <string name="tabSwitcherGridViewMenu">Grid view</string>
 
     <!--Tab Switcher Animation-->
-    <string name="trackersBlockedInTheLast7days" instruction="Placeholder is the number of trackers blocked">&lt;b&gt;%1$d trackers blocked &lt;/b&gt; in the last 7 days</string>
-    <string name="trackersBlocked" instruction="Placeholder is the number of trackers blocked">&lt;b&gt;%1$d trackers blocked &lt;/b&gt;</string>
+    <string name="trackersBlockedInTheLast7days" instruction="Placeholder is the number of trackers blocked">&lt;b&gt;%1$s trackers blocked &lt;/b&gt; in the last 7 days</string>
+    <string name="trackersBlocked" instruction="Placeholder is the number of trackers blocked">&lt;b&gt;%1$s trackers blocked &lt;/b&gt;</string>
     <string name="inTheLast7Days">in the last 7 days</string>
 
     <!-- Fire -->