Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gz-sensors branch in example #1634

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

Now that the gz-sensors7 branch has been created and the main branch has been bumped to version 8 (gazebosim/gz-sensors#254), we should make sure we use the stable branch in the example, otherwise it fails to build.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added bug Something isn't working tests Broken or missing tests / testing infra 🌱 garden Ignition Garden labels Aug 8, 2022
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #1634 (54413ff) into main (d8a3e87) will decrease coverage by 0.01%.
The diff coverage is 61.40%.

❗ Current head 54413ff differs from pull request most recent head cf32cdc. Consider uploading reports for the commit cf32cdc to get more accurate results

@@            Coverage Diff             @@
##             main    #1634      +/-   ##
==========================================
- Coverage   63.57%   63.55%   -0.02%     
==========================================
  Files         330      331       +1     
  Lines       25950    25993      +43     
==========================================
+ Hits        16498    16521      +23     
- Misses       9452     9472      +20     
Impacted Files Coverage Δ
src/systems/diff_drive/DiffDrive.hh 100.00% <ø> (ø)
...rc/systems/odometry_publisher/OdometryPublisher.hh 100.00% <ø> (ø)
src/systems/sensors/Sensors.cc 63.00% <25.00%> (-0.49%) ⬇️
src/rendering/RenderUtil.cc 38.94% <30.00%> (-0.12%) ⬇️
src/SdfEntityCreator.cc 84.77% <33.33%> (-0.37%) ⬇️
...rc/systems/odometry_publisher/OdometryPublisher.cc 87.87% <89.65%> (-0.55%) ⬇️
include/gz/sim/components/BoundingBoxCamera.hh 100.00% <100.00%> (ø)
src/network/PeerInfo.cc 100.00% <0.00%> (+4.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chapulina chapulina merged commit e068b54 into main Aug 9, 2022
@chapulina chapulina deleted the chapulina/gz-sensors7 branch August 9, 2022 15:06
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🌱 garden Ignition Garden tests Broken or missing tests / testing infra
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants