Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename python library as gz.sim7 #1716

Merged
merged 5 commits into from
Sep 16, 2022

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Sep 16, 2022

🦟 Bug fix

Summary

Following gazebosim/gz-math#503 and gazebosim/sdformat#1143

Checklist

  • Signed all commits for DCO
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)

Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
@osrf-triage osrf-triage added this to Inbox in Core development Sep 16, 2022
@j-rivero j-rivero changed the base branch from ign-gazebo6 to gz-sim7 September 16, 2022 14:04
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #1716 (76806c3) into gz-sim7 (22b7852) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 76806c3 differs from pull request most recent head d7bfa83. Consider uploading reports for the commit d7bfa83 to get more accurate results

@@             Coverage Diff             @@
##           gz-sim7    #1716      +/-   ##
===========================================
+ Coverage    63.90%   63.93%   +0.02%     
===========================================
  Files          334      334              
  Lines        26344    26333      -11     
===========================================
  Hits         16836    16836              
+ Misses        9508     9497      -11     
Impacted Files Coverage Δ
python/src/gz/sim/_gz_sim_pybind11.cc 100.00% <100.00%> (+50.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Core development automation moved this from Inbox to In review Sep 16, 2022
@j-rivero j-rivero added 🌱 garden Ignition Garden and removed 🏯 fortress Ignition Fortress labels Sep 16, 2022
@j-rivero j-rivero merged commit 0df8e9e into gz-sim7 Sep 16, 2022
Core development automation moved this from In review to Done Sep 16, 2022
@j-rivero j-rivero deleted the jrivero/move_python_binding_to_versioned branch September 16, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants