Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beakerlib 1.30 (new formula) #164352

Merged
merged 2 commits into from Apr 21, 2024
Merged

beakerlib 1.30 (new formula) #164352

merged 2 commits into from Apr 21, 2024

Conversation

LecrisUT
Copy link
Contributor

@LecrisUT LecrisUT commented Feb 27, 2024

This is a dependency for tmt which I will also add shortly. Basically these are test-frameworks which aim to make reproducible tests locally, in CI, in downstream packaging etc.


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Feb 27, 2024
Formula/b/beakerlib.rb Outdated Show resolved Hide resolved
@LecrisUT
Copy link
Contributor Author

@SMillerDev What should I do with:

Formulae should not require patches to build. Patches should be submitted and accepted upstream first

I have opened a PR upstream beakerlib/beakerlib#170

@SMillerDev
Copy link
Member

Wait until it's released

@LecrisUT
Copy link
Contributor Author

LecrisUT commented Mar 4, 2024

Wait until it's released

Would appreciate an alternative, e.g. pointing to a git commit/branch etc. so that we can work with upstream to resolve any Mac specific issues, and upstream doesn't have to release many bug fix releases to get the mac support working. The upstream team do not have a Mac environment.

For example one MacOS specific issue is that I had a glimpse at an error message of:

  ERROR: Non enhanced getopt version detected

@SMillerDev
Copy link
Member

You can still install things locally and host the formula in a personal tap, but in Homebrew core new formulae should not require patches.

@LecrisUT
Copy link
Contributor Author

LecrisUT commented Mar 4, 2024

Sure, but how can we get a CI that would run on MacOS environments on the personal tap, or how to setup homebrew fork/tap to run the CI without the patch check there, etc.?

@SMillerDev
Copy link
Member

https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap

@LecrisUT
Copy link
Contributor Author

LecrisUT commented Mar 4, 2024

Ok, that did the trick. Not sure how to design the tap to be like a staging tap for upstream homebrew, e.g.:

  • Having only smoke tests run on homebrew-core, but on the tap run a full test-suite
  • Running the tap's CI via workflow_run using the upstream's git repo pointing to main, PR etc.

Other automations like creating PRs to homebrew-core, sanitizing formulas before PR, I think I can handle.

@SMillerDev
Copy link
Member

Having only smoke tests run on homebrew-core, but on the tap run a full test-suite

Taps and core are completely separate so you can run whatever commands you like in it.

Running the tap's CI via workflow_run using the upstream's git repo pointing to main, PR etc.

Don't think I know of any project doing this since for most Homebrew is just one of the many running cmake/meson/whatever. Sounds interesting though.

Other automations like creating PRs to homebrew-core

There are GitHub actions that already exist for this, that should make this fairly easy.

@LecrisUT LecrisUT force-pushed the beakerlib branch 2 times, most recently from 2a999d0 to 59b7a10 Compare March 8, 2024 08:58
@LecrisUT LecrisUT changed the title beakerlib 1.29.3 (new formula) beakerlib 1.30 (new formula) Mar 8, 2024
@LecrisUT LecrisUT marked this pull request as ready for review March 8, 2024 08:59
@LecrisUT LecrisUT force-pushed the beakerlib branch 5 times, most recently from 8e7fb0c to ab39a17 Compare March 8, 2024 09:34
@LecrisUT
Copy link
Contributor Author

LecrisUT commented Mar 8, 2024

@SMillerDev help

* Dependency 'gnu-getopt' is provided by macOS; please replace 'depends_on' with 'uses_from_macos'.

#109215 (comment)

This fails on MacOS <=14 without it: https://github.com/Homebrew/homebrew-core/actions/runs/8201410100/job/22430140867

Tried with

uses_from_macos "gnu-getopt", since: :sonoma

but it still fails on me. I think I need an equivalent of since: :greater_than_sonoma or while gnu-getopt is still a formula

Formula/b/beakerlib.rb Outdated Show resolved Hide resolved
Signed-off-by: Cristian Le <[email protected]>
@LecrisUT
Copy link
Contributor Author

LecrisUT commented Apr 11, 2024

Note, beware when updating this package, spglib, etc. The sha256sum is changing after a commit is added: scikit-build/scikit-build-core#695

@bevanjkay bevanjkay added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Apr 19, 2024
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Apr 19, 2024
@LecrisUT
Copy link
Contributor Author

Well, I've rebased if someone wants to do the magic of making the CI work 🤷

@bevanjkay bevanjkay added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Apr 19, 2024
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Apr 21, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 21, 2024
Merged via the queue into Homebrew:master with commit 874018c Apr 21, 2024
14 checks passed
@MikeMcQuaid
Copy link
Member

Thanks @LecrisUT!

@LecrisUT LecrisUT deleted the beakerlib branch April 21, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants