Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmt 1.33.0 (new formula) #164367

Merged
merged 2 commits into from May 10, 2024
Merged

tmt 1.33.0 (new formula) #164367

merged 2 commits into from May 10, 2024

Conversation

LecrisUT
Copy link
Contributor

@LecrisUT LecrisUT commented Feb 27, 2024

Depends on #164352.

This is the main package that requires beakerlib. I am not sure what's the procedure for dependencies, I probably need to add all of the python dependencies as well? If I need to add those dependencies as well, should I make individual PRs for each one?


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Feb 27, 2024
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request python Python use is a significant feature of the PR or issue labels Mar 4, 2024
@LecrisUT
Copy link
Contributor Author

LecrisUT commented Mar 4, 2024

Packaging python packages is confusing. I've updated this PR to show the build failure. Basically it fails at pip install pint which is a dependency of this package. Anyone able to help with this one?

Copy link
Contributor

github-actions bot commented Apr 2, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Apr 2, 2024
@LecrisUT
Copy link
Contributor Author

LecrisUT commented Apr 2, 2024

@Bo98 @SMillerDev Can anyone help me understand the error messages here. It seems to be related to the build dependencies of the python libraries, but I don't quite understand the source of these errors. There doesn't seem to be and --no-build-isolation or such so all of the dependencies should be downloaded from PyPI, but it seems to error at a diamond-like dependency of setuptools_scm:

                              WARNING: Requested setuptools-scm>=6.2.3 from https://files.pythonhosted.org/packages/eb/b1/0248705f10f6de5eefe7ff93e399f7192257b23df4d431d2f5680bb2778f/setuptools-scm-8.0.4.tar.gz (from setuptools-scm[toml]>=6.2.3), but installing version 1.31.0
                            Discarding https://files.pythonhosted.org/packages/eb/b1/0248705f10f6de5eefe7ff93e399f7192257b23df4d431d2f5680bb2778f/setuptools-scm-8.0.4.tar.gz (from https://pypi.org/simple/setuptools-scm/) (requires-python:>=3.8): Requested setuptools-scm>=6.2.3 from https://files.pythonhosted.org/packages/eb/b1/0248705f10f6de5eefe7ff93e399f7192257b23df4d431d2f5680bb2778f/setuptools-scm-8.0.4.tar.gz (from setuptools-scm>=6.2.3) has inconsistent version: expected '8.0.4', but metadata has '1.31.0'
                              Using cached setuptools-scm-8.0.3.tar.gz (72 kB)
                            ERROR: Exception:
...
     note: This error originates from a subprocess, and is likely not a problem with pip.
    full command: /home/linuxbrew/.linuxbrew/Cellar/tmt/1.31.0/libexec/bin/python /home/linuxbrew/.linuxbrew/lib/python3.12/site-packages/pip/__pip-runner__.py install --ignore-installed --no-user --prefix /tmp/pip-build-env-37tmqw71/overlay --no-warn-script-location --no-binary :all: --only-binary :none: -i https://pypi.org/simple -- 'setuptools>=41' wheel 'setuptools_scm[toml]>=3.4.3'

@github-actions github-actions bot removed the stale No recent activity label Apr 2, 2024
@LecrisUT LecrisUT marked this pull request as ready for review April 18, 2024 19:55
@LecrisUT LecrisUT requested review from MikeMcQuaid and a team as code owners April 18, 2024 19:55
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what the build failure is here and it's not output by Homebrew so we're not the best people to ask.

@LecrisUT
Copy link
Contributor Author

I don't know what the build failure is here and it's not output by Homebrew so we're not the best people to ask.

Actually this is core to how homebrew exposes the packaging index to pip install and the build is failing because it is picking up an incosistent version of setuptools-scm:

    Collecting setuptools_scm>=3.4.3 (from setuptools_scm[toml]>=3.4.3)
      Downloading setuptools-scm-8.0.4.tar.gz (74 kB)
         ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 74.3/74.3 kB 3.5 MB/s eta 0:00:00
      Installing build dependencies: started
      Installing build dependencies: finished with status 'done'
      Getting requirements to build wheel: started
      Getting requirements to build wheel: finished with status 'done'
      Installing backend dependencies: started
      Installing backend dependencies: finished with status 'done'
      Preparing metadata (pyproject.toml): started
      Preparing metadata (pyproject.toml): finished with status 'done'
      WARNING: Requested setuptools_scm>=3.4.3 from https://files.pythonhosted.org/packages/eb/b1/0248705f10f6de5eefe7ff93e399f7192257b23df4d431d2f5680bb2778f/setuptools-scm-8.0.4.tar.gz (from setuptools_scm[toml]>=3.4.3), but installing version 1.31.0
    Discarding https://files.pythonhosted.org/packages/eb/b1/0248705f10f6de5eefe7ff93e399f7192257b23df4d431d2f5680bb2778f/setuptools-scm-8.0.4.tar.gz (from https://pypi.org/simple/setuptools-scm/) (requires-python:>=3.8): Requested setuptools_scm>=3.4.3 from https://files.pythonhosted.org/packages/eb/b1/0248705f10f6de5eefe7ff93e399f7192257b23df4d431d2f5680bb2778f/setuptools-scm-8.0.4.tar.gz (from setuptools_scm>=3.4.3) has inconsistent version: expected '8.0.4', but metadata has '1.31.0'
      Downloading setuptools-scm-8.0.3.tar.gz (72 kB)
         ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 72.8/72.8 kB 10.8 MB/s eta 0:00:00
      Installing build dependencies: started
      Installing build dependencies: finished with status 'error'
      error: subprocess-exited-with-error

As you see it requested and downloaded setuptools-scm 8.0.3, but for some reason it picked up 1.31.0. The only reference about 1.31.0 is in the tmt version itself, which, why did it pick that one up?

Formula/t/tmt.rb Outdated Show resolved Hide resolved
@LecrisUT LecrisUT changed the title tmt 1.31.0 (new formula) tmt 1.32.1 (new formula) Apr 19, 2024
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Apr 19, 2024
@LecrisUT
Copy link
Contributor Author

Seems to work now, just waiting on beakerlib right now

@chenrui333
Copy link
Member

got some jsonschema issue

$ tmt --version
Traceback (most recent call last):
  File "/opt/homebrew/bin/tmt", line 5, in <module>
    from tmt.__main__ import run_cli
  File "/opt/homebrew/Cellar/tmt/1.32.1/libexec/lib/python3.12/site-packages/tmt/__init__.py", line 20, in <module>
    from tmt.base import Clean, Plan, Run, Status, Story, Test, Tree
  File "/opt/homebrew/Cellar/tmt/1.32.1/libexec/lib/python3.12/site-packages/tmt/base.py", line 28, in <module>
    import fmf
  File "/opt/homebrew/Cellar/tmt/1.32.1/libexec/lib/python3.12/site-packages/fmf/__init__.py", line 12, in <module>
    from fmf.base import Tree
  File "/opt/homebrew/Cellar/tmt/1.32.1/libexec/lib/python3.12/site-packages/fmf/base.py", line 11, in <module>
    import jsonschema
ModuleNotFoundError: No module named 'jsonschema'

@chenrui333 chenrui333 changed the title tmt 1.32.1 (new formula) tmt 1.33.0 (new formula) May 9, 2024
@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label May 9, 2024
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label May 9, 2024
Signed-off-by: Cristian Le <[email protected]>

Co-authored-by: Rui Chen <[email protected]>
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 10, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue May 10, 2024
Merged via the queue into Homebrew:master with commit 0548fa3 May 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants