rubocops/lines: audit std_npm_args usage

[branchvincent]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

Wanted to add an audit to help migrate existing std_npm_install_args usage to std_npm_args. This is my first time looking at our rubocops so help is greatly appreciated :)

My plan was to test this out and merge Homebrew/homebrew-core#178538 without bottles, but that triggers our existing audit: Use Language::Node for npm install args. So not sure how we want to sequence this, maybe I should first remove the older audit in a separate PR

[MikeMcQuaid]

So not sure how we want to sequence this, maybe I should first remove the older audit in a separate PR

This seems sensible.

[p-linnane]

I'm going to start from Z and work backwards on getting existing stuff updated in core.

[p-linnane]

This should probably check for require "language/node" and flag if it's in formulae with *std_npm_args.

[branchvincent]

thanks! we just need to wait for std_npm_args to land in a stable release. also after a couple no-bottle PRs, I wonder if we are ok updating the rest of core in a syntax-only PR since this should just be a cosmetic change

This should probably check for require "language/node"

Yea agreed, that might be harder since it's still needed/used for detected_node_shebang (although #17773 should cover our existing usage). Maybe we could move it to formula.rb like we do for python/java:

brew/Library/Homebrew/formula.rb

Lines 30 to 31 in 04621ba

	require "language/java"
	require "language/python"

[branchvincent]

core's updated, this is now ready for review

[MikeMcQuaid]

Thanks again @branchvincent!