-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rubocops/lines: audit std_npm_args
usage
#17867
Conversation
960f3b5
to
bc727f2
Compare
This seems sensible. |
bc727f2
to
45eaa4b
Compare
I'm going to start from Z and work backwards on getting existing stuff updated in core. |
This should probably check for |
thanks! we just need to wait for
Yea agreed, that might be harder since it's still needed/used for brew/Library/Homebrew/formula.rb Lines 30 to 31 in 04621ba
|
45eaa4b
to
96c9ea1
Compare
core's updated, this is now ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @branchvincent!
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Wanted to add an audit to help migrate existing
std_npm_install_args
usage tostd_npm_args
. This is my first time looking at our rubocops so help is greatly appreciated :)My plan was to test this out and merge Homebrew/homebrew-core#178538 without bottles, but that triggers our existing audit:
Use Language::Node for npm install args
. So not sure how we want to sequence this, maybe I should first remove the older audit in a separate PR