Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[w*-z*]: use *std_npm_args #178610

Merged
merged 9 commits into from
Jul 30, 2024
Merged

[w*-z*]: use *std_npm_args #178610

merged 9 commits into from
Jul 30, 2024

Conversation

p-linnane
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Related to Homebrew/brew#17867.

@p-linnane p-linnane added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-bottles Merge without publishing bottles CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. labels Jul 26, 2024
@github-actions github-actions bot added the nodejs Node or npm use is a significant feature of the PR or issue label Jul 26, 2024
@p-linnane p-linnane changed the title [w*-z*]: use *std_npm_args [w*-z*]: use *std_npm_args Jul 26, 2024
Signed-off-by: Patrick Linnane <[email protected]>
Signed-off-by: Patrick Linnane <[email protected]>
Signed-off-by: Patrick Linnane <[email protected]>
Signed-off-by: Patrick Linnane <[email protected]>
Signed-off-by: Patrick Linnane <[email protected]>
Signed-off-by: Patrick Linnane <[email protected]>
Signed-off-by: Patrick Linnane <[email protected]>
Signed-off-by: Patrick Linnane <[email protected]>
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 30, 2024
Merged via the queue into master with commit 20525a2 Jul 30, 2024
23 checks passed
@BrewTestBot BrewTestBot deleted the npm-args-w-z branch July 30, 2024 10:15
@branchvincent
Copy link
Member

thanks for the help! @p-linnane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. nodejs Node or npm use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants