cleaner: rewrite node shebangs

[branchvincent]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

Fixes Homebrew/homebrew-core#176257
Closes #17539

This rewrites node shebangs during cleanup, as we do for perl

$ brew install -s typescript && head -1 $(which tsc)
#!/opt/homebrew/opt/node/bin/node

Not sure if we need tests here? rewrite_shebangs doesn't have any yet, happy to try to add some

[Bo98]

Cautiously approve but this will affect a ton of formulae so maybe worth holding until after the next Monday release (already got a lot of other big changes on master that's taken a while to stabilise).

We already have at least one formula that actually tries to undo all the Perl stuff here and that's not a very good sign as Cleaner should never break a formula: Homebrew/homebrew-core@b551b40. There is significantly less Perl formulae than Node formulae.

Ideally we'd have some way to roll this out more gradually.

[MikeMcQuaid]

Cautiously approve but this will affect a ton of formulae so maybe worth holding until after the next Monday release (already got a lot of other big changes on master that's taken a while to stabilise).

Agreed 👍🏻

[MikeMcQuaid]

Approving but marking as draft until next release.

[branchvincent]

how do we feel about merging this now? I'm rebuilding node formulae for #17867 and having this would help us catch any potential issues quickly

[Bo98]

There will likely be a follow up release tonight with #17902 (if approved, else tomorrow).

[MikeMcQuaid]

Thanks @branchvincent, good to go now.