Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a*: use std_npm_args #178538

Merged
merged 17 commits into from
Aug 2, 2024
Merged

a*: use std_npm_args #178538

merged 17 commits into from
Aug 2, 2024

Conversation

branchvincent
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Testing new audit from Homebrew/brew#17867

I did have to manually remove the unnecessary require "language/node", maybe the audit should be smart enough to fix that too

@branchvincent branchvincent added the CI-no-bottles Merge without publishing bottles label Jul 26, 2024
@github-actions github-actions bot added the nodejs Node or npm use is a significant feature of the PR or issue label Jul 26, 2024
@branchvincent branchvincent added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing labels Jul 29, 2024
@branchvincent branchvincent marked this pull request as ready for review July 29, 2024 14:47
@branchvincent branchvincent added the CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. label Jul 29, 2024
@branchvincent branchvincent added the ready to merge PR can be merged once CI is green label Aug 2, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 2, 2024
Merged via the queue into Homebrew:master with commit 9de0de6 Aug 2, 2024
29 checks passed
@branchvincent branchvincent deleted the std_npm_args branch August 2, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. long build Set a long timeout for formula testing nodejs Node or npm use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants