Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unloading stateful check #8749

Merged
merged 1 commit into from
Jul 15, 2024
Merged

fix unloading stateful check #8749

merged 1 commit into from
Jul 15, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Jul 15, 2024

Description

We need to move up the check so it prevents unloading tasks with state.

Testing Instructions

Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 10:32am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 10:32am
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Jul 15, 2024 10:32am
examples-designsystem-docs ⬜️ Ignored (Inspect) Jul 15, 2024 10:32am
examples-gatsby-web ⬜️ Ignored (Inspect) Jul 15, 2024 10:32am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jul 15, 2024 10:32am
examples-native-web ⬜️ Ignored (Inspect) Jul 15, 2024 10:32am
examples-svelte-web ⬜️ Ignored (Inspect) Jul 15, 2024 10:32am
examples-tailwind-web ⬜️ Ignored (Inspect) Jul 15, 2024 10:32am
examples-vite-web ⬜️ Ignored (Inspect) Jul 15, 2024 10:32am

Copy link
Member Author

sokra commented Jul 15, 2024

@sokra sokra changed the title Remove recursive flag from doc. (#8688) fix unloading Jul 15, 2024
@sokra sokra changed the title fix unloading fix unloading stateful check Jul 15, 2024
@sokra sokra marked this pull request as ready for review July 15, 2024 10:34
@sokra sokra requested a review from a team as a code owner July 15, 2024 10:34
Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

✅ This change can build next-swc

@sokra sokra requested a review from arlyon July 15, 2024 10:36
Copy link
Contributor

github-actions bot commented Jul 15, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit 5bfb689 into main Jul 15, 2024
56 of 58 checks passed
@sokra sokra deleted the sokra/fix-unloading branch July 15, 2024 15:17
sokra added a commit to vercel/next.js that referenced this pull request Jul 16, 2024
* vercel/turborepo#8721 <!-- Tobias Koppers - fix
equal checks for cells and output -->
* vercel/turborepo#8671 <!-- Tobias Koppers - add
unloading of tasks to GC -->
* vercel/turborepo#8749 <!-- Tobias Koppers - fix
unloading stateful check -->
* vercel/turborepo#8750 <!-- Tobias Koppers -
upgrade deps to avoid conflict with next.js -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

We need to move up the check so it prevents unloading tasks with state.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

We need to move up the check so it prevents unloading tasks with state.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

We need to move up the check so it prevents unloading tasks with state.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

We need to move up the check so it prevents unloading tasks with state.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 16, 2024
* vercel/turborepo#8721 <!-- Tobias Koppers - fix
equal checks for cells and output -->
* vercel/turborepo#8671 <!-- Tobias Koppers - add
unloading of tasks to GC -->
* vercel/turborepo#8749 <!-- Tobias Koppers - fix
unloading stateful check -->
* vercel/turborepo#8750 <!-- Tobias Koppers -
upgrade deps to avoid conflict with next.js -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants