Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

box Scheduled task state to save memory #8807

Merged
merged 1 commit into from
Jul 24, 2024
Merged

box Scheduled task state to save memory #8807

merged 1 commit into from
Jul 24, 2024
+41 −43

Conversation

sokra
Copy link
Member

@sokra sokra commented Jul 22, 2024 •
edited
Loading

Description

This makes the enum smaller for the Done state, which is the common one

Testing Instructions

@sokra sokra mentioned this pull request Jul 22, 2024
Merged
@vercel Vercel
Copy link

vercel bot commented Jul 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 6:56pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 6:56pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 6:56pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 6:56pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 6:56pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 6:56pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 6:56pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 6:56pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 6:56pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 6:56pm

@sokra sokra mentioned this pull request Jul 22, 2024
Merged
@sokra Graphite App
Copy link
Member Author

sokra commented Jul 22, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sokra and the rest of your teammates on Graphite Graphite

@sokra sokra mentioned this pull request Jul 22, 2024
Merged
@sokra sokra marked this pull request as ready for review July 22, 2024 16:51
@sokra sokra requested a review from a team as a code owner July 22, 2024 16:51
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 22, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 22, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra requested a review from arlyon July 23, 2024 06:47
@sokra sokra requested review from anthonyshew and a team as code owners July 23, 2024 12:46
@sokra sokra requested review from mehulkar and removed request for a team July 23, 2024 12:46
@sokra sokra changed the base branch from sokra/excessive-cells to sokra/refactor-read-cell July 23, 2024 12:46
@sokra sokra mentioned this pull request Jul 23, 2024
Merged
Base automatically changed from sokra/refactor-read-cell to main July 24, 2024 18:51
@sokra Graphite App
Copy link
Member Author

sokra commented Jul 24, 2024 •
edited
Loading

Merge activity

  • Jul 24, 2:51 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Jul 24, 3:16 PM EDT: @sokra merged this pull request with Graphite.

@sokra sokra merged commit 1e3ddb9 into main Jul 24, 2024
55 of 56 checks passed
@sokra sokra deleted the sokra/box-scheduled branch July 24, 2024 19:16
@sokra sokra mentioned this pull request Jul 24, 2024
Merged
sokra added a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
update turbopack (#68129)
6af8da5 
* vercel/turborepo#8812 <!-- Benjamin Woodruff -
Simplify some of the syntax used with VcRead<T> -->
* vercel/turborepo#8823 <!-- hrmny -
feat(turbopack): support analysing string concatenation -->
* vercel/turborepo#8828 <!-- Tobias Koppers - change
from failsafe_analyse to failsafe_parse -->
* vercel/turborepo#8831 <!-- Alexander Lyon - make
sure that all the taiki-e/install-action calls use our env -->
* vercel/turborepo#8819 <!-- Tobias Koppers -
Refactor cell reading to handle removed cells -->
* vercel/turborepo#8038 <!-- Alexander Lyon - add
tags to turbo tasks -->
* vercel/turborepo#8807 <!-- Tobias Koppers - box
Scheduled task state to save memory -->
* vercel/turborepo#8170 <!-- Tobias Koppers - Drop
excessive cells after task reexecution -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
box Scheduled task state to save memory (vercel/turborepo#8807)
c1e2ba8 
### Description

This makes the enum smaller for the Done state, which is the common one

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
box Scheduled task state to save memory (vercel/turborepo#8807)
f9ef4fb 
### Description

This makes the enum smaller for the Done state, which is the common one

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
box Scheduled task state to save memory (vercel/turborepo#8807)
f0af48b 
### Description

This makes the enum smaller for the Done state, which is the common one

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
box Scheduled task state to save memory (vercel/turborepo#8807)
c8d2bc5 
### Description

This makes the enum smaller for the Done state, which is the common one

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 14, 2024
@sokra @ForsakenHarmony
update turbopack (#68129)
4bcaa7c 
* vercel/turborepo#8812 <!-- Benjamin Woodruff -
Simplify some of the syntax used with VcRead<T> -->
* vercel/turborepo#8823 <!-- hrmny -
feat(turbopack): support analysing string concatenation -->
* vercel/turborepo#8828 <!-- Tobias Koppers - change
from failsafe_analyse to failsafe_parse -->
* vercel/turborepo#8831 <!-- Alexander Lyon - make
sure that all the taiki-e/install-action calls use our env -->
* vercel/turborepo#8819 <!-- Tobias Koppers -
Refactor cell reading to handle removed cells -->
* vercel/turborepo#8038 <!-- Alexander Lyon - add
tags to turbo tasks -->
* vercel/turborepo#8807 <!-- Tobias Koppers - box
Scheduled task state to save memory -->
* vercel/turborepo#8170 <!-- Tobias Koppers - Drop
excessive cells after task reexecution -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 15, 2024
@sokra @ForsakenHarmony
update turbopack (#68129)
d3efcd8 
* vercel/turborepo#8812 <!-- Benjamin Woodruff -
Simplify some of the syntax used with VcRead<T> -->
* vercel/turborepo#8823 <!-- hrmny -
feat(turbopack): support analysing string concatenation -->
* vercel/turborepo#8828 <!-- Tobias Koppers - change
from failsafe_analyse to failsafe_parse -->
* vercel/turborepo#8831 <!-- Alexander Lyon - make
sure that all the taiki-e/install-action calls use our env -->
* vercel/turborepo#8819 <!-- Tobias Koppers -
Refactor cell reading to handle removed cells -->
* vercel/turborepo#8038 <!-- Alexander Lyon - add
tags to turbo tasks -->
* vercel/turborepo#8807 <!-- Tobias Koppers - box
Scheduled task state to save memory -->
* vercel/turborepo#8170 <!-- Tobias Koppers - Drop
excessive cells after task reexecution -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 16, 2024
@sokra @ForsakenHarmony
update turbopack (#68129)
8c637af 
* vercel/turborepo#8812 <!-- Benjamin Woodruff -
Simplify some of the syntax used with VcRead<T> -->
* vercel/turborepo#8823 <!-- hrmny -
feat(turbopack): support analysing string concatenation -->
* vercel/turborepo#8828 <!-- Tobias Koppers - change
from failsafe_analyse to failsafe_parse -->
* vercel/turborepo#8831 <!-- Alexander Lyon - make
sure that all the taiki-e/install-action calls use our env -->
* vercel/turborepo#8819 <!-- Tobias Koppers -
Refactor cell reading to handle removed cells -->
* vercel/turborepo#8038 <!-- Alexander Lyon - add
tags to turbo tasks -->
* vercel/turborepo#8807 <!-- Tobias Koppers - box
Scheduled task state to save memory -->
* vercel/turborepo#8170 <!-- Tobias Koppers - Drop
excessive cells after task reexecution -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arlyon arlyon arlyon approved these changes

@anthonyshew anthonyshew Awaiting requested review from anthonyshew

@mehulkar mehulkar Awaiting requested review from mehulkar mehulkar is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
created-by: turbopack owned-by: turbopack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @arlyon