Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unloading stateful check #8749

Merged
merged 1 commit into from
Jul 15, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions crates/turbo-tasks-memory/src/task.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1621,22 +1621,22 @@ impl Task {
}
state.gc.generation = None;

if active {
let mut cells_to_drop = Vec::new();

match &mut state.state_type {
TaskStateType::Done { stateful, edges: _ } => {
if *stateful {
return GcResult::NotPossible;
}
}
TaskStateType::Dirty { .. } => {}
_ => {
// GC can't run in this state. We will reschedule it when the execution
// completes.
match &mut state.state_type {
TaskStateType::Done { stateful, edges: _ } => {
if *stateful {
return GcResult::NotPossible;
}
}
TaskStateType::Dirty { .. } => {}
_ => {
// GC can't run in this state. We will reschedule it when the execution
// completes.
return GcResult::NotPossible;
}
}

if active {
let mut cells_to_drop = Vec::new();

// shrinking memory and dropping cells
state.aggregation_node.shrink_to_fit();
Expand Down
Loading