-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to yuma #223
Comments
With taggers:
- GN2v01
- DL1dv01
reference_tagger: GN2v01 I get a warning
Adding this to the above list |
I think this is as expected. In the default example config, we have a series of ROC plots. We have defined - args:
signal: bjets
x_range: [0.5, 1.0]
include_taggers: ['GN2v01']
- args:
signal: bjets
x_range: [0.5, 1.0]
exclude_taggers: ['GN2v01'] What is happening is for the first plot, we have include_taggers: 'GN2v01'. This is fine, the code is happy, as GN2v01 is the default reference tagger. For the second plot, we have exclude_taggers: 'GN2v01', so it will show all other taggers (in this case, only DL1dv01). When it is showing this plot, it doesn't have the reference tagger, as we've excluded it, so it automatically sets DL1dv01 as the reference tagger in this plot. If you wanted to remove the warning you would add `reference: DL1dv01' to the plot config above. I think this is the same error for the point "Fix bug where yuma crashes with one configured tagger", if you have only 1 tagger, and you exclude that tagger, then it'll have nothing to plot. I'll add in an exception here to make it clearer. |
Hey, I noticed that when using yuma it ignores the taggers selection in the plot config and plots every tagger that is defined in taggers.yaml |
Yuma, introduced in #204 , allows for plotting common flavour tagging results via a yaml config, reducing requirements for boilerplate.
Some areas that could probably still be implemented
ttbar_bjets_probs_pb__.png
andttbar_bjets_roc_.png
Results
/Tagger
classes, and we should have single way to load taggers into the results object, whereas at the moment we haveload
,add_taggers_from_file
andload_taggers_from_file
Results
atlas tags, and also when we select the taggers to plotThe text was updated successfully, but these errors were encountered: