Skip to content

Fix ROC x-range configuration for yuma #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

samvanstroud
Copy link
Contributor

@samvanstroud samvanstroud commented Feb 20, 2024

Summary

This pull request introduces the following changes

  • x_range is passed as an argument, rather than going through a attribute on the Results object

Relates to the following issues

Conformity

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (84dabfb) 97.22% compared to head (c015f6c) 97.24%.

❗ Current head c015f6c differs from pull request most recent head b6e069b. Consider uploading reports for the commit b6e069b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
+ Coverage   97.22%   97.24%   +0.01%     
==========================================
  Files          46       46              
  Lines        4650     4644       -6     
==========================================
- Hits         4521     4516       -5     
+ Misses        129      128       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samvanstroud samvanstroud merged commit 38d4a0b into main Feb 20, 2024
@samvanstroud samvanstroud deleted the svanstro/fix-yuma-roc-xrange branch February 20, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant