Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better filenames when using the high level API #256

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

samvanstroud
Copy link
Contributor

@samvanstroud samvanstroud commented Mar 7, 2024

Summary

This pull request introduces the following changes

  • Better filenames when using the high level API
  • Plots are put into nested dir

Relates to the following issues

Conformity

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 99.04762% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.80%. Comparing base (5865133) to head (979f376).

Files Patch % Lines
puma/hlplots/results.py 98.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #256   +/-   ##
=======================================
  Coverage   97.80%   97.80%           
=======================================
  Files          43       43           
  Lines        4637     4656   +19     
=======================================
+ Hits         4535     4554   +19     
  Misses        102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samvanstroud samvanstroud merged commit 4adc5c0 into main Mar 7, 2024
9 checks passed
@samvanstroud samvanstroud deleted the svanstro/cleanup-filenames branch March 7, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant