Fix wielding two-handed items with only one hand #40966
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Title
Thanks to @VerinSenpai for writing an integration test that found this bug.
To reproduce on master:
removehandcommand so that you only have one handWhy / Balance
bugfix
Technical details
CanWieldwas comparing the number of freeable hands. However that included the hand the weapon was held in, which should not count as dropable when trying to wield it.To fix this we add a new method to count free hands that can ignore a given item when counting.
We cannot just subtract 1 because the weapon itself might be unremoveable.
Media
Requirements
Breaking changes
Changelog
🆑