Skip to content

Add integration test for wielding and multi-handed items #41028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add integration test for wielding and multi-handed items #41028

wants to merge 2 commits into from
+610 −53

Conversation

slarticodefast
Copy link
Member

About the PR

Stuff breaks all the time and wielding has been broken for ages without anyone fixing it.
Requires #40966 first so the test can pass.
Supercedes #40977 (sorry Verin). This test is more comprehensive.

Why / Balance

bugs bad, tests good

Technical details

Adds a bunch of helper methods and makes the wielding API use the Entity<T> pattern and a resolve.

Requirements

Breaking changes

The CanWield, TryWield and TryUnwield methods now take an Entity<WieldableComponent?> as a parameter.

Changelog
not player facing

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/M Denotes a PR that changes 100-999 lines. labels Oct 21, 2025
@slarticodefast slarticodefast added A: Integration Tests Area: Integration tests, adding or fixing them A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A: General Interactions Area: General in-game interactions that don't relate to another area. A: Integration Tests Area: Integration tests, adding or fixing them S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/M Denotes a PR that changes 100-999 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@slarticodefast @PJBot